public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com,
	pmg-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH widget-manager/backup/pmg v3] fix: #3971 Tasklog download button
Date: Tue, 11 Oct 2022 15:58:59 +0200	[thread overview]
Message-ID: <20221011135902.610515-1-d.tschlatscher@proxmox.com> (raw)

This patch series' aim is to add a download button in the tasklog-
viewer GUI so that users may access the tasklog more easily.
(The tasklog-viewer only displays 50 lines at a time)
Now, when the parameter 'limit' for the /log API call is set to '0',
the backends will stream the file rather than returning a JSON array
with the corresponding lines. (Beforehand, it would return 0 lines)

This patch series revision did not see any changes to the two patches
to be applied in the proxmox-widget-toolkit. Therefore, they are
omitted here. To make this series fully functional, they have to be
applied as well.
However, the widget-toolkit frontend implementation needs all backend
patches to be working properly.


changes from v2
* replaced helper function in pve-commong with inline implementations
  in PMG and PVE backends
* improved API documentation for limit parameter
* minor refactorings


Daniel Tschlatscher (1):
  make tasklog downloadable in the backup server backend

 src/api2/node/tasks.rs | 161 ++++++++++++++++++++++++++---------------
 1 file changed, 103 insertions(+), 58 deletions(-)

Daniel Tschlatscher (1):
  make tasklog downloadable in the PMG backend

 src/PMG/API2/Tasks.pm | 44 ++++++++++++++++++++++++-------------------
 1 file changed, 25 insertions(+), 19 deletions(-)

Daniel Tschlatscher (1):
  make task log downloadable in the PVE manager backend

 PVE/API2/Tasks.pm | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

-- 
2.30.2





             reply	other threads:[~2022-10-11 14:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11 13:58 Daniel Tschlatscher [this message]
2022-10-11 13:59 ` [pbs-devel] [PATCH backup v3] make tasklog downloadable in the backup server backend Daniel Tschlatscher
2022-10-11 13:59 ` [pbs-devel] [PATCH pmg-api v3] make tasklog downloadable in the PMG backend Daniel Tschlatscher
2022-10-11 13:59 ` [pbs-devel] [PATCH manager v3] make task log downloadable in the PVE manager backend Daniel Tschlatscher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221011135902.610515-1-d.tschlatscher@proxmox.com \
    --to=d.tschlatscher@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal