[pbs-devel] [PATCH v2 widget-toolkit] CSS: import action column fix from pbs, pmg

[pbs-devel] [PATCH v2 widget-toolkit] CSS: import action column fix from pbs, pmg

[Matthias Heiserer]

So it is in one location and available to pve as well.


Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---

Changes from v1:
Use the correct style from pbs, and not the older, unused one one.
13px -> 14px


 src/css/ext6-pmx.css | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/src/css/ext6-pmx.css b/src/css/ext6-pmx.css
index 886e24a..231b4ce 100644
--- a/src/css/ext6-pmx.css
+++ b/src/css/ext6-pmx.css
@@ -274,3 +274,20 @@ div.right-aligned {
 /* markdown tables end */
 
 /* markdown content end */
+
+/* action column fix start */
+.x-action-col-icon {
+    margin: 0 1px;
+    font-size: 14px;
+}
+.x-action-col-icon:before, .x-action-col-icon:after {
+    font-size: 14px;
+}
+.x-action-col-icon:hover:before, .x-action-col-icon:hover:after {
+    text-shadow: 1px 1px 1px #AAA;
+    font-weight: 800;
+}
+.x-action-col-icon:before {
+	color: #555;
+    }
+/* action column fix end */
-- 
2.30.2

[pbs-devel] [PATCH v2 pmg-gui] CSS: move action column fix to widget-toolkit

[Matthias Heiserer]

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---

Changes from v1:
None

 css/ext6-pmg.css | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/css/ext6-pmg.css b/css/ext6-pmg.css
index d994774..3dedf45 100644
--- a/css/ext6-pmg.css
+++ b/css/ext6-pmg.css
@@ -130,15 +130,6 @@ table:not(.x-grid-item-selected) tr.x-grid-row.disabled {
     color: #cfcfcf;
 }
 
-/* fix action column icons */
-.x-action-col-icon {
-    font-size: 14px;
-}
-
-.x-action-col-icon:before {
-    color: #555;
-}
-
 .x-treelist-item-icon {
     color: #000;
 }
-- 
2.30.2

[pbs-devel] [PATCH v2 proxmox-backup 1/2] GUI: CSS: remove redundant action column style

[Matthias Heiserer]

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---

Changes from v1:
remove both action column styles

 www/css/ext6-pbs.css | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css
index 3c8bed55..7fc60eee 100644
--- a/www/css/ext6-pbs.css
+++ b/www/css/ext6-pbs.css
@@ -127,20 +127,6 @@ table:not(.x-grid-item-selected) tr.x-grid-row.disabled {
     color: #cfcfcf;
 }
 
-/* fix action column icons */
-.x-action-col-icon {
-    font-size: 13px;
-    height: 13px;
-}
-
-.x-grid-cell-inner-action-col {
-    padding: 6px 10px 5px;
-}
-
-.x-action-col-icon:before {
-    color: #555;
-}
-
 .x-treelist-item-icon {
     color: #000;
 }
-- 
2.30.2

Re: [pbs-devel] [PATCH v2 proxmox-backup 1/2] GUI: CSS: remove redundant action column style

[Thomas Lamprecht]

Am 07/10/2022 um 13:18 schrieb Matthias Heiserer:
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
> 
> Changes from v1:
> remove both action column styles
> 
>  www/css/ext6-pbs.css | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css
> index 3c8bed55..7fc60eee 100644
> --- a/www/css/ext6-pbs.css
> +++ b/www/css/ext6-pbs.css
> @@ -127,20 +127,6 @@ table:not(.x-grid-item-selected) tr.x-grid-row.disabled {
>      color: #cfcfcf;
>  }
>  
> -/* fix action column icons */
> -.x-action-col-icon {
> -    font-size: 13px;
> -    height: 13px;
> -}
> -
> -.x-grid-cell-inner-action-col {
> -    padding: 6px 10px 5px;
> -}

^- above rule gets lost and bloats up vertical padding quite a bit in the progress,
there's no commit message so a bit hard to tell, but just from the subject I'd think
that this is meant to be done, or?


> -
> -.x-action-col-icon:before {
> -    color: #555;
> -}
> -
>  .x-treelist-item-icon {
>      color: #000;
>  }

Re: [pbs-devel] [PATCH v2 proxmox-backup 1/2] GUI: CSS: remove redundant action column style

[Matthias Heiserer]

On 28.11.2022 08:32, Thomas Lamprecht wrote:
> Am 07/10/2022 um 13:18 schrieb Matthias Heiserer:
>> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
>> ---
>>
>> Changes from v1:
>> remove both action column styles
>>
>>   www/css/ext6-pbs.css | 14 --------------
>>   1 file changed, 14 deletions(-)
>>
>> diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css
>> index 3c8bed55..7fc60eee 100644
>> --- a/www/css/ext6-pbs.css
>> +++ b/www/css/ext6-pbs.css
>> @@ -127,20 +127,6 @@ table:not(.x-grid-item-selected) tr.x-grid-row.disabled {
>>       color: #cfcfcf;
>>   }
>>   
>> -/* fix action column icons */
>> -.x-action-col-icon {
>> -    font-size: 13px;
>> -    height: 13px;
>> -}
>> -
>> -.x-grid-cell-inner-action-col {
>> -    padding: 6px 10px 5px;
>> -}
> 
> ^- above rule gets lost and bloats up vertical padding quite a bit in the progress,
> there's no commit message so a bit hard to tell, but just from the subject I'd think
> that this is meant to be done, or?
I figured we want to have the same style on all products.
Should I send a v2 and keep this line in PBS, or add it to the widget 
toolkit?

> 
>> -
>> -.x-action-col-icon:before {
>> -    color: #555;
>> -}
>> -
>>   .x-treelist-item-icon {
>>       color: #000;
>>   }
> 

[pbs-devel] [PATCH v2 proxmox-backup 2/2] GUI: CSS: move action columns fix to widget-toolkit

[Matthias Heiserer]

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---

Changes from v1:
remove both action column styles

 www/css/ext6-pbs.css | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css
index 7fc60eee..9d5be8b5 100644
--- a/www/css/ext6-pbs.css
+++ b/www/css/ext6-pbs.css
@@ -231,18 +231,6 @@ span.snapshot-comment-column {
     content: "V.";
 }
 
-.x-action-col-icon {
-    margin: 0 1px;
-    font-size: 14px;
-}
-.x-action-col-icon:before, .x-action-col-icon:after {
-    font-size: 14px;
-}
-.x-action-col-icon:hover:before, .x-action-col-icon:hover:after {
-    text-shadow: 1px 1px 1px #AAA;
-    font-weight: 800;
-}
-
 .pbs-maintenance-mask div.x-mask-msg-text {
     background: None;
     padding: 12px 0 0;
-- 
2.30.2

[pbs-devel] applied: [pmg-devel] [PATCH v2 proxmox-backup 2/2] GUI: CSS: move action columns fix to widget-toolkit

[Thomas Lamprecht]

Am 07/10/2022 um 13:18 schrieb Matthias Heiserer:
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
> 
> Changes from v1:
> remove both action column styles
> 
>  www/css/ext6-pbs.css | 12 ------------
>  1 file changed, 12 deletions(-)
> 
>

applied and bumped the versioned dependency for proxmox-widget-toolkit to
>= 3.5.2, thanks!

[pbs-devel] applied: [pve-devel] [PATCH v2 widget-toolkit] CSS: import action column fix from pbs, pmg

[Thomas Lamprecht]

Am 07/10/2022 um 13:18 schrieb Matthias Heiserer:
> So it is in one location and available to pve as well.
> 
> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
> 
> Changes from v1:
> Use the correct style from pbs, and not the older, unused one one.
> 13px -> 14px
> 
> 
>  src/css/ext6-pmx.css | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
>

applied, this one now, thanks! PBS and somewhat PMG need to wait until widget-toolki
including this got packaged and then need a version dependency on the new version.