From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Mira Limbeck <m.limbeck@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-http] http: fix proxy authorization header to include type
Date: Thu, 21 Jul 2022 13:46:16 +0200 [thread overview]
Message-ID: <20220721114616.f74gqbo44xlo3pro@casey.proxmox.com> (raw)
In-Reply-To: <443436b7-6b7e-e93b-b193-c3d8e1535a10@proxmox.com>
On Thu, Jul 21, 2022 at 01:32:32PM +0200, Thomas Lamprecht wrote:
> Am 20/07/2022 um 16:20 schrieb Mira Limbeck:
> > and encode the username:password string as base64 [0]. This fixes the
> > error 407 issue when using proxy authentication [1].
>
> does this break setups that configured "Basic base64-encoded-pw" themselves though,
> or was that never possible (e.g., due to schema not allowing that)?
That would break other things. Eg. `ProxyConfig;:to_proxy_string` uses
it to build "http://<authorization>@<host>" strings, so the "Basic "
prefix and base64 encoding would break those.
However, we also build such headers in src/client/simple.rs which should
will need the same change I suppose?
next prev parent reply other threads:[~2022-07-21 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 14:20 Mira Limbeck
2022-07-21 10:56 ` [pbs-devel] applied: " Wolfgang Bumiller
2022-07-21 11:32 ` [pbs-devel] " Thomas Lamprecht
2022-07-21 11:46 ` Wolfgang Bumiller [this message]
2022-07-22 9:50 ` Mira Limbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220721114616.f74gqbo44xlo3pro@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=m.limbeck@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox