[pbs-devel] [PATCH proxmox-backup] GUI: CSS: move action columns fix to widget-toolkit

[pbs-devel] [PATCH proxmox-backup] GUI: CSS: move action columns fix to widget-toolkit

[Matthias Heiserer]

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
 www/css/ext6-pbs.css | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css
index 3c8bed55..7fc60eee 100644
--- a/www/css/ext6-pbs.css
+++ b/www/css/ext6-pbs.css
@@ -127,20 +127,6 @@ table:not(.x-grid-item-selected) tr.x-grid-row.disabled {
     color: #cfcfcf;
 }
 
-/* fix action column icons */
-.x-action-col-icon {
-    font-size: 13px;
-    height: 13px;
-}
-
-.x-grid-cell-inner-action-col {
-    padding: 6px 10px 5px;
-}
-
-.x-action-col-icon:before {
-    color: #555;
-}
-
 .x-treelist-item-icon {
     color: #000;
 }
-- 
2.30.2

[pbs-devel] [PMG-GUI] CSS: action columns: move fix to widget-toolkit

[Matthias Heiserer]

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
 css/ext6-pmg.css | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/css/ext6-pmg.css b/css/ext6-pmg.css
index d994774..3dedf45 100644
--- a/css/ext6-pmg.css
+++ b/css/ext6-pmg.css
@@ -130,15 +130,6 @@ table:not(.x-grid-item-selected) tr.x-grid-row.disabled {
     color: #cfcfcf;
 }
 
-/* fix action column icons */
-.x-action-col-icon {
-    font-size: 14px;
-}
-
-.x-action-col-icon:before {
-    color: #555;
-}
-
 .x-treelist-item-icon {
     color: #000;
 }
-- 
2.30.2

[pbs-devel] [PATCH widget-toolkit] CSS: import action column fix from pbs, pmg

[Matthias Heiserer]

So it is in one location and available to pve as well.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
 src/css/ext6-pmx.css | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/src/css/ext6-pmx.css b/src/css/ext6-pmx.css
index 886e24a..2286003 100644
--- a/src/css/ext6-pmx.css
+++ b/src/css/ext6-pmx.css
@@ -274,3 +274,18 @@ div.right-aligned {
 /* markdown tables end */
 
 /* markdown content end */
+
+/* fix action column icons */
+.x-action-col-icon:before {
+    color: #555;
+}
+
+.x-action-col-icon {
+    font-size: 13px;
+    height: 13px;
+}
+
+.x-grid-cell-inner-action-col {
+    padding: 6px 10px 5px;
+}
+/* fix action column icons end*/
\ No newline at end of file
-- 
2.30.2

Re: [pbs-devel] [PATCH widget-toolkit] CSS: import action column fix from pbs, pmg

[Thomas Lamprecht]

Am 20/07/2022 um 14:22 schrieb Matthias Heiserer:
> So it is in one location and available to pve as well.
> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>  src/css/ext6-pmx.css | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/src/css/ext6-pmx.css b/src/css/ext6-pmx.css
> index 886e24a..2286003 100644
> --- a/src/css/ext6-pmx.css
> +++ b/src/css/ext6-pmx.css
> @@ -274,3 +274,18 @@ div.right-aligned {
>  /* markdown tables end */
>  
>  /* markdown content end */
> +
> +/* fix action column icons */
> +.x-action-col-icon:before {
> +    color: #555;
> +}
> +
> +.x-action-col-icon {
> +    font-size: 13px;
> +    height: 13px;
> +}

this is using the outdated/wrong ones, the font awesome icons we use are 14px.
Please use the modern ones from PBS and maybe add the additional ones, like:

.x-action-col-icon {
    margin: 0 1px;
    font-size: 14px;
}
.x-action-col-icon:before, .x-action-col-icon:after {
    font-size: 14px;
}
.x-action-col-icon:hover:before, .x-action-col-icon:hover:after {
    text-shadow: 1px 1px 1px #AAA;
    font-weight: 800;
}

Note that it's a bit confusing because in PBS the previous & wrong 13px font-size
rule didn't get removed..


> +
> +.x-grid-cell-inner-action-col {
> +    padding: 6px 10px 5px;
> +}
> +/* fix action column icons end*/
> \ No newline at end of file

Re: [pbs-devel] [PATCH widget-toolkit] CSS: import action column fix from pbs, pmg

[Matthias Heiserer]

On 05.10.2022 17:45, Thomas Lamprecht wrote:
> Am 20/07/2022 um 14:22 schrieb Matthias Heiserer:
>> So it is in one location and available to pve as well.
>>
>> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
>> ---
>>   src/css/ext6-pmx.css | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>
>> diff --git a/src/css/ext6-pmx.css b/src/css/ext6-pmx.css
>> index 886e24a..2286003 100644
>> --- a/src/css/ext6-pmx.css
>> +++ b/src/css/ext6-pmx.css
>> @@ -274,3 +274,18 @@ div.right-aligned {
>>   /* markdown tables end */
>>   
>>   /* markdown content end */
>> +
>> +/* fix action column icons */
>> +.x-action-col-icon:before {
>> +    color: #555;
>> +}
>> +
>> +.x-action-col-icon {
>> +    font-size: 13px;
>> +    height: 13px;
>> +}
> 
> this is using the outdated/wrong ones, the font awesome icons we use are 14px.
> Please use the modern ones from PBS and maybe add the additional ones, like:
> 
> .x-action-col-icon {
>      margin: 0 1px;
>      font-size: 14px;
> }
> .x-action-col-icon:before, .x-action-col-icon:after {
>      font-size: 14px;
> }
> .x-action-col-icon:hover:before, .x-action-col-icon:hover:after {
>      text-shadow: 1px 1px 1px #AAA;
>      font-weight: 800;
> }
> 
> Note that it's a bit confusing because in PBS the previous & wrong 13px font-size
> rule didn't get removed..
Oh, good catch. I was confused myself because I only saw the 13px ones 
and figured we intentionally use a different size there. Will fix it in v2.
> 
> 
>> +
>> +.x-grid-cell-inner-action-col {
>> +    padding: 6px 10px 5px;
>> +}
>> +/* fix action column icons end*/
>> \ No newline at end of file
>