From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Stefan Sterz <s.sterz@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH proxmox-backup] api-types: doc: add crate to `Display` trait in comments
Date: Thu, 30 Jun 2022 10:16:52 +0200 [thread overview]
Message-ID: <20220630081652.uufrff4pcabdsuy3@casey.proxmox.com> (raw)
In-Reply-To: <20220629085538.72950-1-s.sterz@proxmox.com>
applied, thanks
On Wed, Jun 29, 2022 at 10:55:38AM +0200, Stefan Sterz wrote:
> when creating the documentation (e.g. `cargo doc --open`), it would
> warn that `Display` is not in scope.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> pbs-api-types/src/datastore.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
> index 86201b8e..70b639ea 100644
> --- a/pbs-api-types/src/datastore.rs
> +++ b/pbs-api-types/src/datastore.rs
> @@ -579,7 +579,7 @@ impl BackupNamespace {
> Ok(())
> }
>
> - /// Return an adapter which [`Display`]s as a path with `"ns/"` prefixes in front of every
> + /// Return an adapter which [`fmt::Display`]s as a path with `"ns/"` prefixes in front of every
> /// component.
> pub fn display_as_path(&self) -> BackupNamespacePath {
> BackupNamespacePath(self)
> @@ -691,7 +691,7 @@ impl ApiType for BackupNamespace {
>
> /// Helper to format a [`BackupNamespace`] as a path component of a [`BackupGroup`].
> ///
> -/// This implements [`Display`] such that it includes the `ns/` subdirectory prefix in front of
> +/// This implements [`fmt::Display`] such that it includes the `ns/` subdirectory prefix in front of
> /// every component.
> pub struct BackupNamespacePath<'a>(&'a BackupNamespace);
>
> --
> 2.30.2
prev parent reply other threads:[~2022-06-30 8:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 8:55 [pbs-devel] " Stefan Sterz
2022-06-30 8:16 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630081652.uufrff4pcabdsuy3@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox