From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox/proxmox-backup] fix #2915: stat when necessary
Date: Tue, 28 Jun 2022 13:13:15 +0200 [thread overview]
Message-ID: <20220628111318.2648586-1-d.csapak@proxmox.com> (raw)
this series implements a fallback to stat'ing files when the
readdir entry does not contain the filetype (since only some
filesystems support that)
i opted for adding the 'FileStat' to the callback in 'scandir'
(even if we don't use it yet) so that we'll not stat again
sometimes when using that. If we want, we can of course omit
that part, then the interface stays as it currently is
we could also write our own 'ReadDir' that stats on demand, but given
how few cases we have where we actually use it, i am not so sure
if the benefits justify the work
proxmox:
Dominik Csapak (1):
partially fix #2915: proxmox-sys: scandir: stat if file_type is
unknown
proxmox-sys/src/fs/read_dir.rs | 36 ++++++++++++++++++++++++++++++----
1 file changed, 32 insertions(+), 4 deletions(-)
proxmox-backup:
Dominik Csapak (2):
adapt to changed callback signature of 'scandir'
partially fix #2915: 'stat' in case ReadDirEntry does not contain type
pbs-datastore/src/backup_info.rs | 23 ++++++++-----
pbs-datastore/src/chunk_store.rs | 23 ++++++-------
pbs-datastore/src/hierarchy.rs | 56 ++++++++++++++++++++++++++++++++
src/tools/disks/zfs.rs | 2 +-
4 files changed, 81 insertions(+), 23 deletions(-)
--
2.30.2
next reply other threads:[~2022-06-28 11:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 11:13 Dominik Csapak [this message]
2022-06-28 11:13 ` [pbs-devel] [PATCH proxmox 1/1] partially fix #2915: proxmox-sys: scandir: stat if file_type is unknown Dominik Csapak
2022-06-28 11:45 ` Wolfgang Bumiller
2022-06-28 11:13 ` [pbs-devel] [PATCH proxmox-backup 1/2] adapt to changed callback signature of 'scandir' Dominik Csapak
2022-06-28 11:47 ` Fabian Grünbichler
2022-06-28 11:13 ` [pbs-devel] [PATCH proxmox-backup 2/2] partially fix #2915: 'stat' in case ReadDirEntry does not contain type Dominik Csapak
2022-06-28 11:47 ` Fabian Grünbichler
2022-06-28 11:49 ` Wolfgang Bumiller
2022-06-28 11:52 ` Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628111318.2648586-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox