From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH proxmox-backup] restore-daemon: make file listing 'streaming'
Date: Tue, 21 Jun 2022 10:48:17 +0200 [thread overview]
Message-ID: <20220621084817.gxijquc3ncxxgagr@casey.proxmox.com> (raw)
In-Reply-To: <20220620075113.730615-1-d.csapak@proxmox.com>
applied, thanks
On Mon, Jun 20, 2022 at 09:51:13AM +0200, Dominik Csapak wrote:
> this prevents an oom kill when listing large directories.
> Without this, i'd get an oom kill in the restore vm when
> i tried to list a directory with ~60000 entries, but with this,
> i'd get the response for even 250000 entries
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> at 250000 files, the gui did not work anymore, but that's a different
> problem altogether (i got 'Maximum call stack size exceeded' in extjs code)
>
> proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs b/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs
> index aeb5a71d..91afe5e3 100644
> --- a/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs
> +++ b/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs
> @@ -116,6 +116,7 @@ fn get_dir_entry(path: &Path) -> Result<DirEntryAttribute, Error> {
> }
>
> #[api(
> + streaming: true,
> input: {
> properties: {
> "path": {
> --
> 2.30.2
prev parent reply other threads:[~2022-06-21 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 7:51 [pbs-devel] " Dominik Csapak
2022-06-21 8:48 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621084817.gxijquc3ncxxgagr@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox