From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup/proxmox-widget-toolkit v2 0/4] add partitions to disks/list endpointg
Date: Wed, 15 Jun 2022 11:09:51 +0200 [thread overview]
Message-ID: <20220615090951.dqlzrsbjwblfydwz@wobu-vie.proxmox.com> (raw)
In-Reply-To: <20220608085154.11271-1-h.laimer@proxmox.com>
applied series, thanks
On Wed, Jun 08, 2022 at 08:51:50AM +0000, Hannes Laimer wrote:
> In order to work with the existing frontend component for displying the
> disklist, either
> * the partition data has to be return with the same struct a disk is
> returned. Which leads to the same struct being used for different
> things -> quite a few fields are always empty for partitions and a new
> 'type' field would be needed. Also the code structure in PBS has to be
> changed quite a bit.
> * the existing frontend has to be adjusted to handle data from PVE and
> PBS properly.
>
> I went with the second option because the adjustments nedded in the UI
> compenent were minimal and, IMHO, adjusting the API to fit the UI is the
> wrong direction.
>
> For the mount status to shown in the UI, the patch[1] sent to pve-devel for
> the 'mounted' column is needed.
>
> NOTE: The partition data will be needed in later patches for removable
> datastores.
>
> v1->v2:
> * use builder pattern for queries as suggested by Wolfgang
> * move mounted out of Enum and add filesystem string
> * add missing zfsreserve usage type
> * add 'mounted' column to disklist (separate patch[1])
>
>
> [1] https://lists.proxmox.com/pipermail/pve-devel/2022-June/053211.html
>
> * proxmox-backup
> Hannes Laimer (3):
> api2: disks endpoint return partitions
> disks: use builder pattern for querying disk usage
> ui: disks: show partitions by default
>
> src/api2/node/disks/directory.rs | 6 +-
> src/api2/node/disks/mod.rs | 19 ++-
> src/api2/node/disks/zfs.rs | 2 +-
> src/tools/disks/mod.rs | 206 +++++++++++++++++++++++++++++--
> www/panel/StorageAndDisks.js | 1 +
> 5 files changed, 215 insertions(+), 19 deletions(-)
>
> * proxmox-widget-toolkit
> Hannes Laimer (1):
> ui: DiskLisk: handle partition data from PBS backend
>
> src/panel/DiskList.js | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> --
> 2.30.2
prev parent reply other threads:[~2022-06-15 9:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 8:51 [pbs-devel] [PATCH proxmox-backup/proxmox-widget-toolkit v2 0/4] add partitions to disks/list endpoint Hannes Laimer
2022-06-08 8:51 ` [pbs-devel] [PATCH proxmox-backup v2 1/3] api2: disks endpoint return partitions Hannes Laimer
2022-06-08 8:51 ` [pbs-devel] [PATCH proxmox-backup v2 2/3] disks: use builder pattern for querying disk usage Hannes Laimer
2022-06-09 10:38 ` Wolfgang Bumiller
2022-06-15 6:07 ` [pbs-devel] [PATCH proxmox-backup v3 " Hannes Laimer
2022-06-15 6:17 ` Hannes Laimer
2022-06-08 8:51 ` [pbs-devel] [PATCH proxmox-backup v2 3/3] ui: disks: show partitions by default Hannes Laimer
2022-06-08 8:51 ` [pbs-devel] [PATCH proxmox-widget-toolkit v2 1/1] ui: DiskLisk: handle partition data from PBS backend Hannes Laimer
2022-06-15 8:58 ` [pbs-devel] applied: " Wolfgang Bumiller
2022-06-15 7:58 ` [pbs-devel] [PATCH proxmox-backup/proxmox-widget-toolkit v2 0/4] add partitions to disks/list endpoint Wolfgang Bumiller
2022-06-15 8:08 ` Dominik Csapak
2022-06-15 8:10 ` Hannes Laimer
2022-06-15 8:17 ` Wolfgang Bumiller
2022-06-15 9:09 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615090951.dqlzrsbjwblfydwz@wobu-vie.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox