From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup rebased 3/9] pbs-datastore: replace print with log macro
Date: Tue, 31 May 2022 10:44:27 +0200 [thread overview]
Message-ID: <20220531084427.ce26vuaztp2nxpk3@casey.proxmox.com> (raw)
In-Reply-To: <20220510090158.33504-5-h.laimer@proxmox.com>
On Tue, May 10, 2022 at 09:01:52AM +0000, Hannes Laimer wrote:
> --- a/pbs-datastore/src/fixed_index.rs
> +++ b/pbs-datastore/src/fixed_index.rs
> @@ -51,7 +51,7 @@ unsafe impl Sync for FixedIndexReader {}
> impl Drop for FixedIndexReader {
> fn drop(&mut self) {
> if let Err(err) = self.unmap() {
> - eprintln!("Unable to unmap file - {}", err);
> + log::error!("Unable to unmap file - {}", err);
> }
> }
> }
> @@ -144,16 +144,16 @@ impl FixedIndexReader {
> }
>
> pub fn print_info(&self) {
AFAICT this entire function is unused and could just be removed (as a
separate patch)
> - println!("Size: {}", self.size);
> - println!("ChunkSize: {}", self.chunk_size);
> + log::info!("Size: {}", self.size);
> + log::info!("ChunkSize: {}", self.chunk_size);
>
> let mut ctime_str = self.ctime.to_string();
> if let Ok(s) = proxmox_time::strftime_local("%c", self.ctime) {
> ctime_str = s;
> }
>
> - println!("CTime: {}", ctime_str);
> - println!("UUID: {:?}", self.uuid);
> + log::info!("CTime: {}", ctime_str);
> + log::info!("UUID: {:?}", self.uuid);
> }
> }
>
next prev parent reply other threads:[~2022-05-31 8:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 9:01 [pbs-devel] [PATCH-SERIES] replace print by log macro in libraries Hannes Laimer
2022-05-10 9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 1/9] bins: init cli logger Hannes Laimer
2022-05-10 9:01 ` [pbs-devel] [PATCH proxmox 1/1] router: add init_cli_logger helper function Hannes Laimer
2022-05-10 9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 2/9] pbs-client: replace print with log macro Hannes Laimer
2022-05-31 8:38 ` Wolfgang Bumiller
2022-05-10 9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 3/9] pbs-datastore: " Hannes Laimer
2022-05-31 8:44 ` Wolfgang Bumiller [this message]
2022-05-10 9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 4/9] pbs-fuse+pbs-tape: " Hannes Laimer
2022-05-10 9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 5/9] proxmox-backup-client: " Hannes Laimer
2022-05-10 9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 6/9] proxmox-file-restore: " Hannes Laimer
2022-05-10 9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 7/9] proxmox-rest-server: " Hannes Laimer
2022-05-10 9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 8/9] " Hannes Laimer
2022-05-31 8:42 ` Wolfgang Bumiller
2022-05-10 9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 9/9] docs: add note for setting verbosity level Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531084427.ce26vuaztp2nxpk3@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox