From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH common/storage/proxmxo-backup v3] improve file-restore timeout behaviour
Date: Fri, 27 May 2022 10:22:00 +0200 [thread overview]
Message-ID: <20220527082203.1653182-1-d.csapak@proxmox.com> (raw)
this series improves the behaviour of the file-restore when some mount
operations take longer than the 30 second pveproxy timeout
some of the previous version was already applied (pbs + gui) so only
the pve part is still missing
i changed the way we return the error a bit from my previous (and
already applied) attempt, namely i couple how we return the error
on the 'output-format' instead of a seperate 'json-error'
while this is technically a change in behaviour, this is imho ok because:
* setting 'output-format' to json(-pretty) did not format the error,
so a tool would have to cope with the pure text
* AFAIK we don't have the same guarantees for the cli as for the api
* it's a much better interface than before
but since this changed, and the 'json-error' was already applied,
the dependencies go as follows:
pve-storage depends on the new proxmox-backup-file-restore/pve-common
to work properly, but it's not broken with the current versions
proxmox-backup breaks the current pve-storage (so that we must bump and
add a 'breaks <<' probably)
the gui should already handle the new code, so that is fine either way
changes from v2:
* couple the error format to 'ouput-format' instead of 'json-error'
* remove 'error' property from 'error json object' (was redundant)
* always expect an error when we get an object and always treat
it as ok when we get a list
changes from v1:
* rebased on master
* moved the json-error and timeout directly into pve-common (hardcoded)
since there is only one usage of that function
pve-common:
Dominik Csapak (1):
PBSClient: file_restore_list: add timeout parameter
src/PVE/PBSClient.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
pve-storage:
Dominik Csapak (1):
api: FileRestore: decode and return proper error with new file-restore
params
PVE/API2/Storage/FileRestore.pm | 21 ++++++++++++++++-----
1 file changed, 16 insertions(+), 5 deletions(-)
proxmox-backup:
Dominik Csapak (1):
file-restore: remove 'json-error' parameter from list_files
proxmox-file-restore/src/main.rs | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
--
2.30.2
next reply other threads:[~2022-05-27 8:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 8:22 Dominik Csapak [this message]
2022-05-27 8:22 ` [pbs-devel] [PATCH common v3 1/1] PBSClient: file_restore_list: add timeout parameter Dominik Csapak
2022-11-07 14:17 ` [pbs-devel] [pve-devel] " Thomas Lamprecht
2022-11-08 11:20 ` Dominik Csapak
2022-11-08 15:53 ` Thomas Lamprecht
2022-11-09 7:07 ` Dominik Csapak
2022-05-27 8:22 ` [pbs-devel] [PATCH storage v3 1/1] api: FileRestore: decode and return proper error with new file-restore params Dominik Csapak
2022-05-27 8:22 ` [pbs-devel] [PATCH proxmox-backup v3 1/1] file-restore: remove 'json-error' parameter from list_files Dominik Csapak
2022-10-05 17:34 ` [pbs-devel] applied: " Thomas Lamprecht
2022-10-25 10:17 ` [pbs-devel] [pve-devel] [PATCH common/storage/proxmxo-backup v3] improve file-restore timeout behaviour Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220527082203.1653182-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox