* [pbs-devel] [PATCH proxmox-backup] ui: datastore/Summary: correctly show the io-delay chart
@ 2022-05-17 7:00 Dominik Csapak
2022-05-17 7:55 ` [pbs-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2022-05-17 7:00 UTC (permalink / raw)
To: pbs-devel
by checking if *any* record has data, not only the first
this would prevent the chart from being shown for e.g. newly added
datastores, or for datastores after the server was offline for some time
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/datastore/Summary.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js
index 3c07d512..a24b10a8 100644
--- a/www/datastore/Summary.js
+++ b/www/datastore/Summary.js
@@ -312,7 +312,8 @@ Ext.define('PBS.DataStoreSummary', {
});
me.mon(me.rrdstore, 'load', function(store, records, success) {
- me.down('#ioDelayChart').setVisible(!success || records[0]?.data?.io_ticks !== undefined);
+ let has_io_ticks = records.some((rec) => rec?.data?.io_ticks !== undefined);
+ me.down('#ioDelayChart').setVisible(!success || has_io_ticks);
}, undefined, { single: true });
me.query('proxmoxRRDChart').forEach((chart) => {
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] ui: datastore/Summary: correctly show the io-delay chart
2022-05-17 7:00 [pbs-devel] [PATCH proxmox-backup] ui: datastore/Summary: correctly show the io-delay chart Dominik Csapak
@ 2022-05-17 7:55 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-05-17 7:55 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Dominik Csapak
Am 5/17/22 um 09:00 schrieb Dominik Csapak:
> by checking if *any* record has data, not only the first
> this would prevent the chart from being shown for e.g. newly added
> datastores, or for datastores after the server was offline for some time
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/datastore/Summary.js | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-17 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-17 7:00 [pbs-devel] [PATCH proxmox-backup] ui: datastore/Summary: correctly show the io-delay chart Dominik Csapak
2022-05-17 7:55 ` [pbs-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox