From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: datastore/Summary: correctly show the io-delay chart
Date: Tue, 17 May 2022 09:00:38 +0200 [thread overview]
Message-ID: <20220517070038.395660-1-d.csapak@proxmox.com> (raw)
by checking if *any* record has data, not only the first
this would prevent the chart from being shown for e.g. newly added
datastores, or for datastores after the server was offline for some time
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/datastore/Summary.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js
index 3c07d512..a24b10a8 100644
--- a/www/datastore/Summary.js
+++ b/www/datastore/Summary.js
@@ -312,7 +312,8 @@ Ext.define('PBS.DataStoreSummary', {
});
me.mon(me.rrdstore, 'load', function(store, records, success) {
- me.down('#ioDelayChart').setVisible(!success || records[0]?.data?.io_ticks !== undefined);
+ let has_io_ticks = records.some((rec) => rec?.data?.io_ticks !== undefined);
+ me.down('#ioDelayChart').setVisible(!success || has_io_ticks);
}, undefined, { single: true });
me.query('proxmoxRRDChart').forEach((chart) => {
--
2.30.2
next reply other threads:[~2022-05-17 7:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 7:00 Dominik Csapak [this message]
2022-05-17 7:55 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517070038.395660-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox