public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH-SERIES] replace print by log macro in libraries
Date: Tue, 10 May 2022 09:01:48 +0000	[thread overview]
Message-ID: <20220510090158.33504-1-h.laimer@proxmox.com> (raw)

This series mostly replaces print with the log macro in libs, it also replaces print
in binaries where it is used to log stuff and not output the result of a command.
In the process of replacing prints by log macros a few parameters controlling verbosity
became obsolete and were removed(outputs that were behind an if(verbose).. are now log::debug),
other 'verbose' parameters influenced the control flow and where therefore kept.

The whole changes were split up into 7 seperate patches[3-9], this was done
to aviod one huge patch file and improve readability. Those (maybe also 2) 
should be squashed when applied since they are not necesarilly buildable. 
The reason for that is that in a few places 'verbose' parameters were remove.

A verion bump is also needed since patches 2 (and indirectly 3-10) depend on 
the function added to proxmox-router in patch 1.

proxmox-backup part of this series was rebased, no other changes.

proxmox:

Hannes Laimer (1):
  router: add init_cli_logger helper function

 proxmox-router/Cargo.toml     |  1 +
 proxmox-router/src/cli/mod.rs | 11 +++++++++++
 2 files changed, 12 insertions(+)


proxmox-backup:

Hannes Laimer (2):
  libs: replace print with log macro
  docs: add note for setting verbosity level

 docs/command-syntax.rst                       |  4 +
 examples/upload-speed.rs                      |  2 +-
 pbs-client/Cargo.toml                         |  1 +
 pbs-client/src/backup_writer.rs               | 93 +++++++-----------
 pbs-client/src/catalog_shell.rs               |  4 +-
 pbs-client/src/http_client.rs                 | 14 +--
 pbs-client/src/pxar/create.rs                 |  2 -
 pbs-client/src/pxar/extract.rs                | 44 +++------
 pbs-client/src/pxar/fuse.rs                   | 18 ++--
 pbs-client/src/pxar/metadata.rs               |  4 +-
 pbs-client/src/pxar_backup_stream.rs          |  6 +-
 pbs-client/src/task_log.rs                    |  8 +-
 pbs-client/src/tools/key_source.rs            |  2 +-
 pbs-datastore/src/catalog.rs                  |  6 +-
 pbs-datastore/src/datastore.rs                |  4 +-
 pbs-datastore/src/dynamic_index.rs            |  2 +-
 pbs-datastore/src/fixed_index.rs              | 14 +--
 pbs-datastore/src/paperkey.rs                 |  2 +-
 pbs-fuse-loop/Cargo.toml                      |  1 +
 pbs-fuse-loop/src/fuse_loop.rs                | 12 +--
 pbs-tape/Cargo.toml                           |  1 +
 pbs-tape/src/bin/pmt.rs                       | 11 ++-
 pbs-tape/src/bin/pmtx.rs                      |  9 +-
 pbs-tape/src/sg_pt_changer.rs                 |  4 +-
 proxmox-backup-client/Cargo.toml              |  1 +
 proxmox-backup-client/src/benchmark.rs        | 31 +++---
 proxmox-backup-client/src/catalog.rs          |  6 +-
 proxmox-backup-client/src/key.rs              | 27 +++---
 proxmox-backup-client/src/main.rs             | 96 ++++++++-----------
 proxmox-backup-client/src/mount.rs            | 12 +--
 proxmox-file-restore/Cargo.toml               |  1 +
 proxmox-file-restore/src/block_driver_qemu.rs |  6 +-
 proxmox-file-restore/src/main.rs              | 23 ++---
 proxmox-file-restore/src/qemu_helper.rs       | 18 ++--
 proxmox-rest-server/src/api_config.rs         |  4 +-
 proxmox-rest-server/src/command_socket.rs     | 10 +-
 proxmox-rest-server/src/file_logger.rs        |  2 +-
 .../src/proxmox_restore_daemon/api.rs         |  1 -
 pxar-bin/Cargo.toml                           |  1 +
 pxar-bin/src/main.rs                          | 50 ++--------
 src/api2/admin/datastore.rs                   |  2 +-
 src/bin/proxmox-backup-debug.rs               |  4 +-
 src/bin/proxmox-backup-manager.rs             |  1 +
 src/bin/proxmox-tape.rs                       |  1 +
 src/bin/sg-tape-cmd.rs                        | 11 ++-
 45 files changed, 238 insertions(+), 338 deletions(-)
-- 
2.30.2





             reply	other threads:[~2022-05-10  9:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10  9:01 Hannes Laimer [this message]
2022-05-10  9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 1/9] bins: init cli logger Hannes Laimer
2022-05-10  9:01 ` [pbs-devel] [PATCH proxmox 1/1] router: add init_cli_logger helper function Hannes Laimer
2022-05-10  9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 2/9] pbs-client: replace print with log macro Hannes Laimer
2022-05-31  8:38   ` Wolfgang Bumiller
2022-05-10  9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 3/9] pbs-datastore: " Hannes Laimer
2022-05-31  8:44   ` Wolfgang Bumiller
2022-05-10  9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 4/9] pbs-fuse+pbs-tape: " Hannes Laimer
2022-05-10  9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 5/9] proxmox-backup-client: " Hannes Laimer
2022-05-10  9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 6/9] proxmox-file-restore: " Hannes Laimer
2022-05-10  9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 7/9] proxmox-rest-server: " Hannes Laimer
2022-05-10  9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 8/9] " Hannes Laimer
2022-05-31  8:42   ` Wolfgang Bumiller
2022-05-10  9:01 ` [pbs-devel] [PATCH proxmox-backup rebased 9/9] docs: add note for setting verbosity level Hannes Laimer
  -- strict thread matches above, loose matches on Subject: below --
2022-03-11 15:07 [pbs-devel] [PATCH-SERIES] replace print by log macro in libraries Hannes Laimer
2022-03-17  8:40 ` Wolfgang Bumiller
2022-03-18  6:02   ` Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220510090158.33504-1-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal