* [pbs-devel] applied: [PATCH] object grid: call rendere with our scope
@ 2022-04-12 14:42 Thomas Lamprecht
0 siblings, 0 replies; only message in thread
From: Thomas Lamprecht @ 2022-04-12 14:42 UTC (permalink / raw)
To: pbs-devel
having window as this scope has zero benefits and while one could
already try to get the local scope via some Ext.ComponentQuery query
its just nicer to have it easily available.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
Stumbled uppon this when wondering about the way Hannes setup the
maintenance mode renderer in his series, this would allow to inline
that
src/grid/ObjectGrid.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/grid/ObjectGrid.js b/src/grid/ObjectGrid.js
index 9f3886e..b355d6d 100644
--- a/src/grid/ObjectGrid.js
+++ b/src/grid/ObjectGrid.js
@@ -248,7 +248,7 @@ Ext.define('Proxmox.grid.ObjectGrid', {
let renderer = rowdef.renderer;
if (renderer) {
- return renderer(value, metaData, record, rowIndex, colIndex, store);
+ return renderer.call(me, value, metaData, record, rowIndex, colIndex, store);
}
return value;
--
2.30.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-04-12 14:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-12 14:42 [pbs-devel] applied: [PATCH] object grid: call rendere with our scope Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox