[pbs-devel] [PATCH proxmox-backup] pbs-client: print error when we couldn't download previous fidx/didx

[pbs-devel] [PATCH proxmox-backup] pbs-client: print error when we couldn't download previous fidx/didx

[Dominik Csapak]

When we have a previous manifest, we try to download the fidx/didx files
to get the known chunks list. We continue if that fails (which is ok),
but we did not print any error, leading to a confusing backup output,
since the users would expect that chunks will be reused.

Printing the error should at least make it apparent that something did
not work correctly.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
i sent it with 'eprintln' instead of the log macro, since that series
was not applied yet. i'll happily resend it when thats done with the log
macro, or i can send it now but i guess then hannes patches will not
apply anymore since i'd have to add the log dependency myself

 pbs-client/src/backup_writer.rs | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/pbs-client/src/backup_writer.rs b/pbs-client/src/backup_writer.rs
index b02798bd..c81182a7 100644
--- a/pbs-client/src/backup_writer.rs
+++ b/pbs-client/src/backup_writer.rs
@@ -289,22 +289,28 @@ impl BackupWriter {
             // try, but ignore errors
             match ArchiveType::from_path(archive_name) {
                 Ok(ArchiveType::FixedIndex) => {
-                    let _ = self
+                    if let Err(err) = self
                         .download_previous_fixed_index(
                             archive_name,
                             &manifest,
                             known_chunks.clone(),
                         )
-                        .await;
+                        .await
+                    {
+                        eprintln!("Error downloading .fidx from previous manifest: {}", err);
+                    }
                 }
                 Ok(ArchiveType::DynamicIndex) => {
-                    let _ = self
+                    if let Err(err) = self
                         .download_previous_dynamic_index(
                             archive_name,
                             &manifest,
                             known_chunks.clone(),
                         )
-                        .await;
+                        .await
+                    {
+                        eprintln!("Error downloading .didx from previous manifest: {}", err);
+                    }
                 }
                 _ => { /* do nothing */ }
             }
-- 
2.30.2

[pbs-devel] applied: [PATCH proxmox-backup] pbs-client: print error when we couldn't download previous fidx/didx

[Dietmar Maurer]

applied