From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [SERIES proxmox-backup proxmox-widget-toolkit 0/3] add partitions to disks/list endpoint
Date: Mon, 4 Apr 2022 09:50:45 +0000 [thread overview]
Message-ID: <20220404095048.25443-1-h.laimer@proxmox.com> (raw)
In order to work with the existing frontend component for displying the
disklist, either
* the partition data has to be return with the same struct a disk is
returned. Which leads to the same struct being used for different
things -> quite a few fields are always empty for partitions and a new
'type' field would be needed. Also the code structure in PBS has to be
changed quite a bit.
* the existing frontend has to be adjusted to handle data from PVE and
PBS properly.
I went with the second option because the adjustments nedded in the UI
compenent were minimal and, IMHO, adjusting the API to fit the UI is the
wrong direction.
Not sure if the small changes in proxmox-widget-toolkit justify sending
this series also to pve-devel.
NOTE: The partition data will be needed in later patches for removable
datastores.
proxmox-backup:
Hannes Laimer (2):
api2: disks endpoint return partitions
ui: disks: show partitions by default
src/api2/node/disks/directory.rs | 2 +-
src/api2/node/disks/mod.rs | 11 ++-
src/api2/node/disks/zfs.rs | 2 +-
src/tools/disks/mod.rs | 121 ++++++++++++++++++++++++++++++-
www/panel/StorageAndDisks.js | 1 +
5 files changed, 131 insertions(+), 6 deletions(-)
proxmox-widget-toolkit:
Hannes Laimer (1):
DiskList: handle partition data from PBS backend
src/panel/DiskList.js | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
--
2.30.2
next reply other threads:[~2022-04-04 9:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 9:50 Hannes Laimer [this message]
2022-04-04 9:50 ` [pbs-devel] [PATCH proxmox-backup 1/3] api2: disks endpoint return partitions Hannes Laimer
2022-04-06 9:12 ` Wolfgang Bumiller
2022-04-04 9:50 ` [pbs-devel] [PATCH proxmox-widget-toolkit 2/2] DiskList: handle partition data from PBS backend Hannes Laimer
2022-04-07 8:37 ` Dominik Csapak
2022-04-04 9:50 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: disks: show partitions by default Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220404095048.25443-1-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox