public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 0/2] let users control the amount of task logs saved
Date: Fri, 25 Mar 2022 12:43:39 +0100	[thread overview]
Message-ID: <20220325114341.3220536-1-d.csapak@proxmox.com> (raw)

by providing a 'task-log-max-days' property which controls how many
days (approximately) we save.

simpler way would be to configure the amount of archive files, but
that does not really translate into a nice user setting (that concept
is not really visible to users)

alternatively we could change the logrotation that it rotates by
date/time instead of size/filecount.

there is no gui yet, but should not be hard to do and one can do
 proxmox-backup-manager node update --task-log-max-days 365

Dominik Csapak (2):
  config/node: add 'task_log_max_days' config
  rest-server: add option to rotate task logs by 'max_days' instead of
    'max_files'

 proxmox-rest-server/src/worker_task.rs | 49 +++++++++++++++++++++++---
 src/api2/node/config.rs                |  4 +++
 src/bin/proxmox-backup-proxy.rs        |  6 ++++
 src/config/node.rs                     |  4 +++
 4 files changed, 59 insertions(+), 4 deletions(-)

-- 
2.30.2





             reply	other threads:[~2022-03-25 11:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25 11:43 Dominik Csapak [this message]
2022-03-25 11:43 ` [pbs-devel] [PATCH proxmox-backup 1/2] config/node: add 'task_log_max_days' config Dominik Csapak
2022-03-25 11:43 ` [pbs-devel] [PATCH proxmox-backup 2/2] rest-server: add option to rotate task logs by 'max_days' instead of 'max_files' Dominik Csapak
2022-03-28  4:44   ` Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220325114341.3220536-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal