* [pbs-devel] [PATCH proxmox-backup] fix #3934 tape owner-selector to Authid
@ 2022-03-15 13:08 Markus Frank
2022-03-15 14:38 ` Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Markus Frank @ 2022-03-15 13:08 UTC (permalink / raw)
To: pbs-devel
changed pmxUserSelector to pbsAuthidSelector, because it is currently
not possible to restore with a api token via gui.
Signed-off-by: Markus Frank <m.frank@proxmox.com>
---
www/tape/window/TapeRestore.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
index 7a5d3cbf..2322d352 100644
--- a/www/tape/window/TapeRestore.js
+++ b/www/tape/window/TapeRestore.js
@@ -398,10 +398,10 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', {
renderer: Ext.String.htmlEncode,
},
{
- xtype: 'pmxUserSelector',
+ xtype: 'pbsAuthidSelector',
name: 'owner',
fieldLabel: gettext('Owner'),
- emptyText: gettext('Current User'),
+ emptyText: gettext('Current Authentication'),
value: null,
allowBlank: true,
skipEmptyText: true,
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [pbs-devel] [PATCH proxmox-backup] fix #3934 tape owner-selector to Authid
2022-03-15 13:08 [pbs-devel] [PATCH proxmox-backup] fix #3934 tape owner-selector to Authid Markus Frank
@ 2022-03-15 14:38 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-03-15 14:38 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Markus Frank
On 15.03.22 14:08, Markus Frank wrote:
> changed pmxUserSelector to pbsAuthidSelector, because it is currently
> not possible to restore with a api token via gui.
>
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> www/tape/window/TapeRestore.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
> index 7a5d3cbf..2322d352 100644
> --- a/www/tape/window/TapeRestore.js
> +++ b/www/tape/window/TapeRestore.js
> @@ -398,10 +398,10 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', {
> renderer: Ext.String.htmlEncode,
> },
> {
> - xtype: 'pmxUserSelector',
> + xtype: 'pbsAuthidSelector',
> name: 'owner',
> fieldLabel: gettext('Owner'),
> - emptyText: gettext('Current User'),
> + emptyText: gettext('Current Authentication'),
We do not use "Authentication" in any gettext currently, besides indirectly in TFA,
and for that specific use case we agreed on using "Auth ID", so can you please change
it to that in a v2?
> value: null,
> allowBlank: true,
> skipEmptyText: true,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-15 14:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-15 13:08 [pbs-devel] [PATCH proxmox-backup] fix #3934 tape owner-selector to Authid Markus Frank
2022-03-15 14:38 ` Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox