From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: Markus Frank <m.frank@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3] fix #3854 paperkey import to proxmox-tape
Date: Fri, 4 Mar 2022 13:31:09 +0100 [thread overview]
Message-ID: <20220304123109.scnkcitqimt3iul5@wobu-vie.proxmox.com> (raw)
In-Reply-To: <93ec49a4-4790-0aef-a763-723f5177ecd5@proxmox.com>
On Fri, Mar 04, 2022 at 12:50:07PM +0100, Dominik Csapak wrote:
> On 3/4/22 12:02, Wolfgang Bumiller wrote:
> > nit: @Dominik (since you suggested it):
> > do we really want `-file` as a suffix here?
> >
> > We have these currently:
> > in recover:
> > --file
> > --keyfile (without the dash), and
> > in 'inspect':
> > --chunk => chunk file
> > --decode => apparently where to decode*to* 🤔
> > --keyfile (also no dash)
> > manager's 'acme':
> > --data => path to plugin-data file
> >
> > should we just use `--paperkey` here?
>
> meh...
>
> '--paperkey': would fit into the existing scheme, but implies
> giving the content, not a file...
I disagree.
>
> '--paperkeyfile': it's ugly
>
> so i suggested '--paperkey-file'...
>
> but we can ofc use '--paperkey' here, maybe try
> to use the content directly if it isn't an existing path?
Please no!
Well... @Markus, your choice, you can pick one of `--paperkey` or
`--paperkey-file`,
(and maybe we should rename `--keyfile` to `--key-file`...)
prev parent reply other threads:[~2022-03-04 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 11:26 Markus Frank
2022-03-04 11:02 ` Wolfgang Bumiller
2022-03-04 11:50 ` Dominik Csapak
2022-03-04 12:31 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304123109.scnkcitqimt3iul5@wobu-vie.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox