From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup v1 1/1] close #3770: pbs-client: add quiet backup flag
Date: Fri, 4 Mar 2022 10:12:36 +0100 [thread overview]
Message-ID: <20220304091236.vldevpvyr2s452vb@wobu-vie.proxmox.com> (raw)
In-Reply-To: <20220222122729.46421-1-h.laimer@proxmox.com>
On Tue, Feb 22, 2022 at 12:27:29PM +0000, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> this feels 'chunky', having quiet and verbose(which is sometimes called
> debug). Maybe some kind general verbosity enum might make sense, but then
> it should not just be used here.
Agreed!
A more general approach might be good.
I think we should be more strict about using the log crate's macros
(`log::info!(...)`, `log::error!(...)`, `log::debug!(...)`) and not use
`println!`/`eprintln!` at all, and have a way to control this (and
potentially the target output ) on a per-task basis. (Eg. via
thread-locals and wrapper Futures which set those before `poll()`ing the
inner future)
prev parent reply other threads:[~2022-03-04 9:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 12:27 Hannes Laimer
2022-03-04 9:12 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304091236.vldevpvyr2s452vb@wobu-vie.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox