From: Stefan Sterz <s.sterz@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v2 0/5] fix #3067: add notes functionality to webui
Date: Thu, 24 Feb 2022 15:18:49 +0100 [thread overview]
Message-ID: <20220224141854.3153101-1-s.sterz@proxmox.com> (raw)
This series adds support for comments/notes to a PBS node similar to
PVE's datacenter or node notes. It's split in two parts, the first two
commits add support for a single line comment, similar to the comments
already available for datastores. The next three commits refactor this
into Markdown-based multi-line comments and add an additional tab to
the UI to provide more space. If prefered, I can squash the commits.
changes v2 (thanks @ Wolfgang Bumiller):
* performance improvements when parsing/writing a node configuration
* adjusted multi-line regex to remove superfluous "\s*"
* better formatting of rust code
Stefan Sterz (5):
fix #3067: api: add support for a comment field in node.cfg
fix #3067: pbs ui: add support for a notes field in the dashboard
fix #3067: api: add multi-line comments to node.cfg
fix #3607: ui: make dashboard notes markdown capable
fix #3607: ui: add a separate notes view for longer markdown notes
pbs-api-types/src/lib.rs | 9 ++
src/api2/node/config.rs | 4 +
src/config/node.rs | 14 ++-
src/tools/config.rs | 58 +++++++++++-
www/Dashboard.js | 110 +++++++++++++---------
www/Makefile | 4 +-
www/NavigationTree.js | 6 ++
www/NodeNotes.js | 22 +++++
www/datastore/Summary.js | 6 +-
www/panel/MarkdownNotes.js | 151 ++++++++++++++++++++++++++++++
www/{datastore => panel}/Notes.js | 19 +++-
11 files changed, 348 insertions(+), 55 deletions(-)
create mode 100644 www/NodeNotes.js
create mode 100644 www/panel/MarkdownNotes.js
rename www/{datastore => panel}/Notes.js (81%)
--
2.30.2
next reply other threads:[~2022-02-24 14:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 14:18 Stefan Sterz [this message]
2022-02-24 14:18 ` [pbs-devel] [PATCH proxmox-backup v2 1/5] fix #3067: api: add support for a comment field in node.cfg Stefan Sterz
2022-02-24 14:18 ` [pbs-devel] [PATCH proxmox-backup v2 2/5] fix #3067: pbs ui: add support for a notes field in the dashboard Stefan Sterz
2022-03-01 10:41 ` Dominik Csapak
2022-03-01 11:42 ` Thomas Lamprecht
2022-02-24 14:18 ` [pbs-devel] [PATCH proxmox-backup v2 3/5] fix #3067: api: add multi-line comments to node.cfg Stefan Sterz
2022-02-24 14:18 ` [pbs-devel] [PATCH proxmox-backup v2 4/5] fix #3607: ui: make dashboard notes markdown capable Stefan Sterz
2022-03-01 10:41 ` Dominik Csapak
2022-03-01 11:09 ` Dominik Csapak
2022-02-24 14:18 ` [pbs-devel] [PATCH proxmox-backup v2 5/5] fix #3607: ui: add a separate notes view for longer markdown notes Stefan Sterz
2022-03-01 10:41 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224141854.3153101-1-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox