From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox] proxmox-http: websocket: fix comment about callback
Date: Fri, 4 Feb 2022 10:52:40 +0100 [thread overview]
Message-ID: <20220204095240.2278480-1-d.csapak@proxmox.com> (raw)
this was once a callback in an early version, but it changed to a
channel, but the comment was not updated
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
proxmox-http/src/websocket/mod.rs | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/proxmox-http/src/websocket/mod.rs b/proxmox-http/src/websocket/mod.rs
index 824dc45..551a677 100644
--- a/proxmox-http/src/websocket/mod.rs
+++ b/proxmox-http/src/websocket/mod.rs
@@ -467,7 +467,8 @@ type WebSocketReadResult = Result<(OpCode, Box<[u8]>), WebSocketError>;
///
/// On read, reads the underlying reader and tries to decode the frames and
/// simply returns the data stream.
-/// When it encounters a control frame, calls the given callback.
+/// When it encounters a control frame, sends it via the given sender
+/// to a channel
///
/// Has an internal Buffer for storing incomplete headers.
pub struct WebSocketReader<R: AsyncRead> {
@@ -479,7 +480,7 @@ pub struct WebSocketReader<R: AsyncRead> {
}
impl<R: AsyncRead> WebSocketReader<R> {
- /// Creates a new WebSocketReader with the given CallBack for control frames
+ /// Creates a new WebSocketReader with the given sender for control frames
/// and a default buffer size of 4096.
pub fn new(
reader: R,
--
2.30.2
next reply other threads:[~2022-02-04 9:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 9:52 Dominik Csapak [this message]
2022-02-04 16:18 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220204095240.2278480-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox