public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup 1/1] docs: make external hyperlinks clickable
@ 2022-01-18 14:25 Matthias Heiserer
  2022-01-18 15:42 ` [pbs-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Matthias Heiserer @ 2022-01-18 14:25 UTC (permalink / raw)
  To: pbs-devel

rustdoc lints detected that two external hyperlinks were not clickable.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
 pbs-tape/src/sgutils2.rs | 2 +-
 src/tools/disks/mod.rs   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/pbs-tape/src/sgutils2.rs b/pbs-tape/src/sgutils2.rs
index 33db4b5d..4e241c3b 100644
--- a/pbs-tape/src/sgutils2.rs
+++ b/pbs-tape/src/sgutils2.rs
@@ -90,7 +90,7 @@ impl SgPt {
 
 /// Peripheral device type text (see `inquiry` command)
 ///
-/// see [https://en.wikipedia.org/wiki/SCSI_Peripheral_Device_Type]
+/// see <https://en.wikipedia.org/wiki/SCSI_Peripheral_Device_Type>
 pub const PERIPHERAL_DEVICE_TYPE_TEXT: [&'static str; 32] = [
     "Disk Drive",
     "Tape Drive",
diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs
index 2f7d8ce6..080e4ba6 100644
--- a/src/tools/disks/mod.rs
+++ b/src/tools/disks/mod.rs
@@ -469,7 +469,7 @@ impl Disk {
 
     /// Read block device stats
     ///
-    /// see https://www.kernel.org/doc/Documentation/block/stat.txt
+    /// see <https://www.kernel.org/doc/Documentation/block/stat.txt>
     pub fn read_stat(&self) -> std::io::Result<Option<BlockDevStat>> {
         if let Some(stat) = self.read_sys(Path::new("stat"))? {
             let stat = unsafe { std::str::from_utf8_unchecked(&stat) };
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup 1/1] docs: make external hyperlinks clickable
  2022-01-18 14:25 [pbs-devel] [PATCH proxmox-backup 1/1] docs: make external hyperlinks clickable Matthias Heiserer
@ 2022-01-18 15:42 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-01-18 15:42 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Matthias Heiserer

On 18.01.22 15:25, Matthias Heiserer wrote:
> rustdoc lints detected that two external hyperlinks were not clickable.
> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>  pbs-tape/src/sgutils2.rs | 2 +-
>  src/tools/disks/mod.rs   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!

Amended the commit message slightly though, avoiding a slightly to long
line and mentioning where the link style comes from (markdown).
Anyhow, basically just very minor nits - thx!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-18 15:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-18 14:25 [pbs-devel] [PATCH proxmox-backup 1/1] docs: make external hyperlinks clickable Matthias Heiserer
2022-01-18 15:42 ` [pbs-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal