From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/2] ui: hide rrd chard for io delay if no io_ticks are returned
Date: Tue, 11 Jan 2022 10:27:08 +0100 [thread overview]
Message-ID: <20220111092708.1683867-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20220111092708.1683867-1-d.csapak@proxmox.com>
it makes no sense to show a completely empty graph
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/datastore/Summary.js | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js
index 1616bd57..c3769257 100644
--- a/www/datastore/Summary.js
+++ b/www/datastore/Summary.js
@@ -234,6 +234,8 @@ Ext.define('PBS.DataStoreSummary', {
},
{
xtype: 'proxmoxRRDChart',
+ itemId: 'ioDelayChart',
+ hidden: true,
title: gettext('IO Delay (ms)'),
fields: ['io_delay'],
fieldTitles: [gettext('IO Delay')],
@@ -288,6 +290,10 @@ Ext.define('PBS.DataStoreSummary', {
},
});
+ me.mon(me.rrdstore, 'load', function(store, records, success) {
+ me.down('#ioDelayChart').setVisible(!success || records[0]?.data?.io_ticks !== undefined);
+ }, undefined, { single: true });
+
me.query('proxmoxRRDChart').forEach((chart) => {
chart.setStore(me.rrdstore);
});
--
2.30.2
next prev parent reply other threads:[~2022-01-11 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 9:27 [pbs-devel] [PATCH proxmox-backup 1/2] api/admin/datastore: rrd: do not include io_ticks for zfs datastores Dominik Csapak
2022-01-11 9:27 ` Dominik Csapak [this message]
2022-01-11 9:28 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: hide rrd chard for io delay if no io_ticks are returned Dominik Csapak
2022-01-11 10:46 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] api/admin/datastore: rrd: do not include io_ticks for zfs datastores Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111092708.1683867-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox