[pbs-devel] [PATCH proxmox-backup v4] api: zfs: create zpool with relatime=on

[pbs-devel] [PATCH proxmox-backup v4] api: zfs: create zpool with relatime=on

[Dominik Csapak]

some operations (e.g. garbage collection/restore/etc.) are very read
intensive on the chunks, and having atime=on and relatime=off (zfs default)
makes those write intensive operations too. Additionally, 'ext4' defaults to
relatime, so also change the default for api-created zpools.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
made an error during rebase (i wrote proxmox_sys::run_command instead of
proxmox_sys::command::run_command)... sorry for the noise

 src/api2/node/disks/zfs.rs | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/api2/node/disks/zfs.rs b/src/api2/node/disks/zfs.rs
index 3682d82f..5161d6be 100644
--- a/src/api2/node/disks/zfs.rs
+++ b/src/api2/node/disks/zfs.rs
@@ -273,13 +273,15 @@ pub fn create_zpool(
                 crate::tools::systemd::enable_unit(&import_unit)?;
             }
 
+            let mut command = std::process::Command::new("zfs");
+            command.arg("set");
             if let Some(compression) = compression {
-                let mut command = std::process::Command::new("zfs");
-                command.args(&["set", &format!("compression={}", compression), &name]);
-                task_log!(worker, "# {:?}", command);
-                let output = proxmox_sys::command::run_command(command, None)?;
-                task_log!(worker, "{}", output);
+                command.arg(&format!("compression={}", compression));
             }
+            command.args(&["relatime=on", &name]);
+            task_log!(worker, "# {:?}", command);
+            let output = proxmox_sys::command::run_command(command, None)?;
+            task_log!(worker, "{}", output);
 
             if add_datastore {
                 let lock = pbs_config::datastore::lock_config()?;
-- 
2.30.2

[pbs-devel] applied: [PATCH proxmox-backup v4] api: zfs: create zpool with relatime=on

[Thomas Lamprecht]

On 16.12.21 08:51, Dominik Csapak wrote:
> some operations (e.g. garbage collection/restore/etc.) are very read
> intensive on the chunks, and having atime=on and relatime=off (zfs default)
> makes those write intensive operations too. Additionally, 'ext4' defaults to
> relatime, so also change the default for api-created zpools.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> made an error during rebase (i wrote proxmox_sys::run_command instead of
> proxmox_sys::command::run_command)... sorry for the noise
> 
>  src/api2/node/disks/zfs.rs | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
>

applied, thanks!