* [pbs-devel] [PATCH proxmox-backup] ui: fix opening settings window in datastore panel
@ 2021-12-02 14:26 Dominik Csapak
2021-12-15 14:57 ` [pbs-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-12-02 14:26 UTC (permalink / raw)
To: pbs-devel
When a user directly opened the webui with a fragment that is not
the summary, opening of the 'my settings' window fails because the
initial set of the columns field triggers a state change, which in turn
tries to trigger 'updateColumns'. That fails though, since the columns
were not even rendered yet (because we are on a different tab).
To fix this, simply return when the panel is not rendered yet.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/datastore/Summary.js | 3 +++
1 file changed, 3 insertions(+)
diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js
index 628f0c60..1616bd57 100644
--- a/www/datastore/Summary.js
+++ b/www/datastore/Summary.js
@@ -264,6 +264,9 @@ Ext.define('PBS.DataStoreSummary', {
if (key !== 'summarycolumns') {
return;
}
+ if (!me.rendered) {
+ return;
+ }
Proxmox.Utils.updateColumns(me);
});
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* [pbs-devel] applied: [PATCH proxmox-backup] ui: fix opening settings window in datastore panel
2021-12-02 14:26 [pbs-devel] [PATCH proxmox-backup] ui: fix opening settings window in datastore panel Dominik Csapak
@ 2021-12-15 14:57 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-12-15 14:57 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Dominik Csapak
On 02.12.21 15:26, Dominik Csapak wrote:
> When a user directly opened the webui with a fragment that is not
> the summary, opening of the 'my settings' window fails because the
> initial set of the columns field triggers a state change, which in turn
> tries to trigger 'updateColumns'. That fails though, since the columns
> were not even rendered yet (because we are on a different tab).
>
> To fix this, simply return when the panel is not rendered yet.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/datastore/Summary.js | 3 +++
> 1 file changed, 3 insertions(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-15 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02 14:26 [pbs-devel] [PATCH proxmox-backup] ui: fix opening settings window in datastore panel Dominik Csapak
2021-12-15 14:57 ` [pbs-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox