public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 3/4] backup-client: use () instead of Value as return type
Date: Thu, 28 Oct 2021 11:47:54 +0200	[thread overview]
Message-ID: <20211028094755.3003184-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20211028094755.3003184-1-d.csapak@proxmox.com>

shorter and we do a conversion anyway

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 proxmox-backup-client/src/snapshot.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/proxmox-backup-client/src/snapshot.rs b/proxmox-backup-client/src/snapshot.rs
index 46b1db09..a9976fbe 100644
--- a/proxmox-backup-client/src/snapshot.rs
+++ b/proxmox-backup-client/src/snapshot.rs
@@ -377,7 +377,7 @@ async fn update_notes(param: Value) -> Result<Value, Error> {
     }
 )]
 /// Show protection status of the specified snapshot
-async fn show_protection(param: Value) -> Result<Value, Error> {
+async fn show_protection(param: Value) -> Result<(), Error> {
     let repo = extract_repository_from_value(&param)?;
     let path = required_string_param(&param, "snapshot")?;
 
@@ -411,7 +411,7 @@ async fn show_protection(param: Value) -> Result<Value, Error> {
         );
     }
 
-    Ok(Value::Null)
+    Ok(())
 }
 
 #[api(
@@ -433,7 +433,7 @@ async fn show_protection(param: Value) -> Result<Value, Error> {
     }
 )]
 /// Update Protection Status of a snapshot
-async fn update_protection(protected: bool, param: Value) -> Result<Value, Error> {
+async fn update_protection(protected: bool, param: Value) -> Result<(), Error> {
     let repo = extract_repository_from_value(&param)?;
     let path = required_string_param(&param, "snapshot")?;
 
@@ -451,7 +451,7 @@ async fn update_protection(protected: bool, param: Value) -> Result<Value, Error
 
     client.put(&path, Some(args)).await?;
 
-    Ok(Value::Null)
+    Ok(())
 }
 
 fn protected_cli() -> CliCommandMap {
-- 
2.30.2





  parent reply	other threads:[~2021-10-28  9:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28  9:47 [pbs-devel] [PATCH proxmox-backup 1/4] PruneMark: use copied values instead of references Dominik Csapak
2021-10-28  9:47 ` [pbs-devel] [PATCH proxmox-backup 2/4] PruneMark: implement display without the write! macro Dominik Csapak
2021-10-28  9:47 ` Dominik Csapak [this message]
2021-10-28  9:47 ` [pbs-devel] [PATCH proxmox-backup 4/4] api: admin/datastore: reuse 'is_protected' implementation Dominik Csapak
2021-10-28 10:57 ` [pbs-devel] applied-series: [PATCH proxmox-backup 1/4] PruneMark: use copied values instead of references Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211028094755.3003184-3-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal