From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied series: [PATCH proxmox-backup v3 00/13] add 'protected' setting for snapshots
Date: Thu, 28 Oct 2021 11:33:15 +0200 [thread overview]
Message-ID: <20211028093315.qdktdbsc3mfvcmvv@olga.proxmox.com> (raw)
In-Reply-To: <20211027112238.3758515-1-d.csapak@proxmox.com>
applied series
The mentioned error handling thing is a non-issue as File::create
doesn't use O_EXCL anyway, and the cleanup can be done as follow-up.
On Wed, Oct 27, 2021 at 01:22:25PM +0200, Dominik Csapak wrote:
> this v3 is mostly to provide a current rebase on master, since some of
> the code was moved
>
> add the means to 'protect' a snapshot against pruning and removal by
> adding a file '.protected' in the snapshot folder
>
> in the v2, i opted against syncing the protected flag for two reasons:
> * it gives the admin the choice on each datastore if he wants to keep
> the snapshot or not(if we sync it, we would have to sync it everytime?)
> * it is much simpler to implement
>
> changes from v2:
> * rebase on master
> * increase width of action column (so that all icons are visible)
>
> changes from v1:
> * rebase on master
> * return the PruneMark enum instead of two booleans in compute_prune_info
> * lock the snapshot when setting/removig the flag
> * don't bail if the file does not exist on removal
> * add a 'protected show' command to the client
> * add a docs section to explain the protected flag
>
> changes from rfc:
> * added gui parts
> * added tests
> * fixed a bug (that the test uncovered)
> * add pbs client command
> * prevent removal (also during sync)
>
> Dominik Csapak (13):
> pbs-datastore: add protection info to BackupInfo
> pbs-datastore: skip protected backups in pruning
> add protected info of snapshots to api and task logs
> tests/prune: add tests for protecteded backups
> backup/datastore: prevent protected snapshots to be removed
> pull_store/group: dont try remove locally protected snapshots
> api2: datastore/delete_group: throw error for partially removed group
> api2/admin/datastore: add get/set_protection
> proxmox-backup-client: add 'protected' commands
> ui: PruneInputPanel: add keepReason 'protected' for protected backups
> ui: add protected icon to snapshots
> fix #3602: ui: datastore/Content: add action to set protection status
> docs: add info about protection flag to client docs
>
> docs/backup-client.rst | 19 +++++
> pbs-api-types/src/datastore.rs | 2 +
> pbs-datastore/src/backup_info.rs | 20 ++++-
> pbs-datastore/src/datastore.rs | 61 +++++++++++---
> pbs-datastore/src/prune.rs | 44 ++++++++--
> proxmox-backup-client/src/snapshot.rs | 113 ++++++++++++++++++++++++++
> src/api2/admin/datastore.rs | 111 +++++++++++++++++++++++--
> src/server/prune_job.rs | 6 +-
> src/server/pull.rs | 20 ++++-
> tests/prune.rs | 44 +++++++++-
> www/datastore/Content.js | 77 +++++++++++++++++-
> www/datastore/Prune.js | 4 +
> 12 files changed, 483 insertions(+), 38 deletions(-)
>
> --
> 2.30.2
prev parent reply other threads:[~2021-10-28 9:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 11:22 [pbs-devel] " Dominik Csapak
2021-10-27 11:22 ` [pbs-devel] [PATCH proxmox-backup v3 01/13] pbs-datastore: add protection info to BackupInfo Dominik Csapak
2021-10-28 9:05 ` Wolfgang Bumiller
2021-10-27 11:22 ` [pbs-devel] [PATCH proxmox-backup v3 02/13] pbs-datastore: skip protected backups in pruning Dominik Csapak
2021-10-27 11:22 ` [pbs-devel] [PATCH proxmox-backup v3 03/13] add protected info of snapshots to api and task logs Dominik Csapak
2021-10-28 9:05 ` Wolfgang Bumiller
2021-10-27 11:22 ` [pbs-devel] [PATCH proxmox-backup v3 04/13] tests/prune: add tests for protecteded backups Dominik Csapak
2021-10-27 11:22 ` [pbs-devel] [PATCH proxmox-backup v3 05/13] backup/datastore: prevent protected snapshots to be removed Dominik Csapak
2021-10-27 11:22 ` [pbs-devel] [PATCH proxmox-backup v3 06/13] pull_store/group: dont try remove locally protected snapshots Dominik Csapak
2021-10-27 11:22 ` [pbs-devel] [PATCH proxmox-backup v3 07/13] api2: datastore/delete_group: throw error for partially removed group Dominik Csapak
2021-10-27 11:22 ` [pbs-devel] [PATCH proxmox-backup v3 08/13] api2/admin/datastore: add get/set_protection Dominik Csapak
2021-10-28 9:05 ` Wolfgang Bumiller
2021-10-27 11:22 ` [pbs-devel] [PATCH proxmox-backup v3 09/13] proxmox-backup-client: add 'protected' commands Dominik Csapak
2021-10-28 9:05 ` Wolfgang Bumiller
2021-10-27 11:22 ` [pbs-devel] [PATCH proxmox-backup v3 10/13] ui: PruneInputPanel: add keepReason 'protected' for protected backups Dominik Csapak
2021-10-27 11:22 ` [pbs-devel] [PATCH proxmox-backup v3 11/13] ui: add protected icon to snapshots Dominik Csapak
2021-10-27 11:22 ` [pbs-devel] [PATCH proxmox-backup v3 12/13] fix #3602: ui: datastore/Content: add action to set protection status Dominik Csapak
2021-10-27 11:22 ` [pbs-devel] [PATCH proxmox-backup v3 13/13] docs: add info about protection flag to client docs Dominik Csapak
2021-10-28 9:33 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028093315.qdktdbsc3mfvcmvv@olga.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox