* [pbs-devel] [PATCH proxmox-backup] acme: interpret no TOS as accepted
@ 2021-10-21 9:12 Dominik Csapak
2021-10-22 8:56 ` [pbs-devel] applied: " Wolfgang Bumiller
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-10-21 9:12 UTC (permalink / raw)
To: pbs-devel
some custom ACME endpoints do not have TOS, interpret this as
'the user has accepted the TOS', like we do for PVE.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
probably needs the proxmox-acme-rs patch from [0] to work in all cases
0: https://lists.proxmox.com/pipermail/pmg-devel/2021-October/001867.html
src/bin/proxmox_backup_manager/acme.rs | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/bin/proxmox_backup_manager/acme.rs b/src/bin/proxmox_backup_manager/acme.rs
index 8d929d38..ecf7b2b2 100644
--- a/src/bin/proxmox_backup_manager/acme.rs
+++ b/src/bin/proxmox_backup_manager/acme.rs
@@ -154,7 +154,8 @@ async fn register_account(
false
}
} else {
- false
+ println!("No Terms of Service found, proceeding.");
+ true
};
println!("Attempting to register account with {:?}...", directory);
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] acme: interpret no TOS as accepted
2021-10-21 9:12 [pbs-devel] [PATCH proxmox-backup] acme: interpret no TOS as accepted Dominik Csapak
@ 2021-10-22 8:56 ` Wolfgang Bumiller
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Bumiller @ 2021-10-22 8:56 UTC (permalink / raw)
To: Dominik Csapak; +Cc: pbs-devel
applied
On Thu, Oct 21, 2021 at 11:12:12AM +0200, Dominik Csapak wrote:
> some custom ACME endpoints do not have TOS, interpret this as
> 'the user has accepted the TOS', like we do for PVE.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> probably needs the proxmox-acme-rs patch from [0] to work in all cases
> 0: https://lists.proxmox.com/pipermail/pmg-devel/2021-October/001867.html
>
> src/bin/proxmox_backup_manager/acme.rs | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/bin/proxmox_backup_manager/acme.rs b/src/bin/proxmox_backup_manager/acme.rs
> index 8d929d38..ecf7b2b2 100644
> --- a/src/bin/proxmox_backup_manager/acme.rs
> +++ b/src/bin/proxmox_backup_manager/acme.rs
> @@ -154,7 +154,8 @@ async fn register_account(
> false
> }
> } else {
> - false
> + println!("No Terms of Service found, proceeding.");
> + true
> };
>
> println!("Attempting to register account with {:?}...", directory);
> --
> 2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-22 8:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-21 9:12 [pbs-devel] [PATCH proxmox-backup] acme: interpret no TOS as accepted Dominik Csapak
2021-10-22 8:56 ` [pbs-devel] applied: " Wolfgang Bumiller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox