public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH proxmox-backup] acme: interpret no TOS as accepted
Date: Fri, 22 Oct 2021 10:56:11 +0200	[thread overview]
Message-ID: <20211022085611.fun3ybyqwqqwu6bu@olga.proxmox.com> (raw)
In-Reply-To: <20211021091212.2157971-1-d.csapak@proxmox.com>

applied

On Thu, Oct 21, 2021 at 11:12:12AM +0200, Dominik Csapak wrote:
> some custom ACME endpoints do not have TOS, interpret this as
> 'the user has accepted the TOS', like we do for PVE.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> probably needs the proxmox-acme-rs patch from [0] to work in all cases
> 0: https://lists.proxmox.com/pipermail/pmg-devel/2021-October/001867.html
> 
>  src/bin/proxmox_backup_manager/acme.rs | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/bin/proxmox_backup_manager/acme.rs b/src/bin/proxmox_backup_manager/acme.rs
> index 8d929d38..ecf7b2b2 100644
> --- a/src/bin/proxmox_backup_manager/acme.rs
> +++ b/src/bin/proxmox_backup_manager/acme.rs
> @@ -154,7 +154,8 @@ async fn register_account(
>              false
>          }
>      } else {
> -        false
> +        println!("No Terms of Service found, proceeding.");
> +        true
>      };
>  
>      println!("Attempting to register account with {:?}...", directory);
> -- 
> 2.30.2




      reply	other threads:[~2021-10-22  8:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21  9:12 [pbs-devel] " Dominik Csapak
2021-10-22  8:56 ` Wolfgang Bumiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211022085611.fun3ybyqwqqwu6bu@olga.proxmox.com \
    --to=w.bumiller@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal