From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/2] tape: improve export_media error message for not found tape
Date: Fri, 15 Oct 2021 10:32:59 +0200 [thread overview]
Message-ID: <20211015083259.1719868-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20211015083259.1719868-1-d.csapak@proxmox.com>
'export_media' can handle if the tape is in either a normal slot of the
library, or in the drive assigned to the current pool writer.
(because we need to lock the drive)
if it is, for some reason, in a different drive, the error message
'media is not online'
could be slightly confusing for a user, since it would appear in the drive list
add the 'or a differen drive' to make it clearer
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/tape/pool_writer/mod.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tape/pool_writer/mod.rs b/src/tape/pool_writer/mod.rs
index 9ff4a173..58995df3 100644
--- a/src/tape/pool_writer/mod.rs
+++ b/src/tape/pool_writer/mod.rs
@@ -159,7 +159,7 @@ impl PoolWriter {
if let Some(slot) = changer.export_media(label_text)? {
task_log!(worker, "exported media '{}' to import/export slot {}", label_text, slot);
} else {
- task_warn!(worker, "export failed - media '{}' is not online", label_text);
+ task_warn!(worker, "export failed - media '{}' is not online or in different drive", label_text);
}
}
--
2.30.2
next prev parent reply other threads:[~2021-10-15 8:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 8:32 [pbs-devel] [PATCH proxmox-backup 1/2] tape: simplify export_media_set for pool writer Dominik Csapak
2021-10-15 8:32 ` Dominik Csapak [this message]
2021-10-18 8:41 ` [pbs-devel] applied: [PATCH proxmox-backup 2/2] tape: improve export_media error message for not found tape Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015083259.1719868-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox