public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [RFC PATCH widget-toolkit/backup] percent encode the task status line
Date: Fri, 15 Oct 2021 10:07:28 +0200	[thread overview]
Message-ID: <20211015080730.1427860-1-d.csapak@proxmox.com> (raw)

to avoid having a newline (and other control characters) in the task status,
percent-encode the last line

decoding happens in the web ui

alternatively, it would make sense to decode it again in the backend
directly, since only the writing into the logfile is problematic. this would
make the api a bit nicer, since an api user would not have to do this
themselves. on the other hand, not having control characters in the api
result makes it a bit safer i suppose...

proxmox-widget-toolkit:

Dominik Csapak (1):
  Utils: percent-decode the task status

 src/Utils.js             | 12 +++++++++++-
 src/panel/LogView.js     |  6 ++++++
 src/window/TaskViewer.js |  2 +-
 3 files changed, 18 insertions(+), 2 deletions(-)

proxmox-backup:

Dominik Csapak (1):
  rest-server: tasks: percent-encode the task status line

 pbs-tools/src/percent_encoding.rs      | 5 +++++
 proxmox-rest-server/src/worker_task.rs | 4 +++-
 2 files changed, 8 insertions(+), 1 deletion(-)

-- 
2.30.2





             reply	other threads:[~2021-10-15  8:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15  8:07 Dominik Csapak [this message]
2021-10-15  8:07 ` [pbs-devel] [RFC PATCH widget-toolkit 1/1] Utils: percent-decode the task status Dominik Csapak
2021-10-15  8:07 ` [pbs-devel] [RFC PATCH proxmox-backup 1/1] rest-server: tasks: percent-encode the task status line Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211015080730.1427860-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal