From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/2] rest-server: add cleanup_old_tasks
Date: Thu, 7 Oct 2021 14:03:36 +0200 [thread overview]
Message-ID: <20211007120337.3723803-1-d.csapak@proxmox.com> (raw)
this is a helper that removes task log files that are not referenced
by the task archive anymore
it gets the oldest task archive file, gets the first endtime (the
oldest) and removes all files in the taskdir where the mtime is older
than that
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
we could check if the filename is a valid UPID, but thought that
would only add unnecessary overhead...
proxmox-rest-server/src/worker_task.rs | 58 ++++++++++++++++++++++++++
1 file changed, 58 insertions(+)
diff --git a/proxmox-rest-server/src/worker_task.rs b/proxmox-rest-server/src/worker_task.rs
index 0ac3f431..51394549 100644
--- a/proxmox-rest-server/src/worker_task.rs
+++ b/proxmox-rest-server/src/worker_task.rs
@@ -5,6 +5,7 @@ use std::io::{Read, Write, BufRead, BufReader};
use std::panic::UnwindSafe;
use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::{Arc, Mutex};
+use std::time::{SystemTime, Duration};
use anyhow::{bail, format_err, Error};
use futures::*;
@@ -218,6 +219,63 @@ pub fn rotate_task_log_archive(size_threshold: u64, compress: bool, max_files: O
logrotate.rotate(size_threshold, None, max_files)
}
+/// removes all task logs that are older than the oldest task entry in the
+/// task archive
+pub fn cleanup_old_tasks(compressed: bool) -> Result<(), Error> {
+ let setup = worker_task_setup()?;
+
+ let _lock = setup.lock_task_list_files(true)?;
+
+ let logrotate = LogRotate::new(&setup.task_archive_fn, compressed)
+ .ok_or_else(|| format_err!("could not get archive file names"))?;
+
+ let mut timestamp = None;
+ if let Some(last_file) = logrotate.files().last() {
+ let reader = BufReader::new(last_file);
+ for line in reader.lines() {
+ let line = line?;
+ if let Ok((_, _, Some(state))) = parse_worker_status_line(&line) {
+ timestamp = Some(state.endtime());
+ break;
+ }
+ }
+ }
+
+ fn get_modified(entry: std::fs::DirEntry) -> Result<SystemTime, std::io::Error> {
+ entry.metadata()?.modified()
+ }
+
+ if let Some(timestamp) = timestamp {
+ let cutoff_time = if timestamp > 0 {
+ SystemTime::UNIX_EPOCH.checked_add(Duration::from_secs(timestamp as u64))
+ } else {
+ SystemTime::UNIX_EPOCH.checked_sub(Duration::from_secs(-timestamp as u64))
+ }.ok_or_else(|| format_err!("could not calculate cutoff time"))?;
+
+ for i in 0..256 {
+ let mut path = setup.taskdir.clone();
+ path.push(format!("{:02X}", i));
+ for file in std::fs::read_dir(path)? {
+ let file = file?;
+ let path = file.path();
+
+ let modified = get_modified(file)
+ .map_err(|err| format_err!("error getting mtime for {:?}: {}", path, err))?;
+
+ if modified < cutoff_time {
+ match std::fs::remove_file(path) {
+ Ok(()) => {},
+ Err(err) if err.kind() == std::io::ErrorKind::NotFound => {},
+ Err(err) => bail!("could not remove file: {}", err),
+ }
+ }
+ }
+ }
+ }
+
+ Ok(())
+}
+
/// Path to the worker log file
pub fn upid_log_path(upid: &UPID) -> Result<std::path::PathBuf, Error> {
--
2.30.2
next reply other threads:[~2021-10-07 12:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 12:03 Dominik Csapak [this message]
2021-10-07 12:03 ` [pbs-devel] [PATCH proxmox-backup 2/2] proxmox-backup-proxy: clean up old tasks when the task log was rotated Dominik Csapak
2021-10-08 4:49 ` [pbs-devel] applied: " Dietmar Maurer
2021-10-08 4:49 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] rest-server: add cleanup_old_tasks Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007120337.3723803-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox