public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/2] ui: datastore/Content: reload in activate listener
Date: Fri,  1 Oct 2021 11:56:54 +0200	[thread overview]
Message-ID: <20211001095655.2678928-1-d.csapak@proxmox.com> (raw)

when we trigger the first load before the panel was fully created,
there was no load mask for it (but the snapshots would "pop in" on load)

move the first reload into the 'activate' listener. this will be called
the every time a user opens the content tab of a datastore, so guard
it by a 'firstLoad' bool.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/datastore/Content.js | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index 57693785..ddc923fd 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -73,7 +73,6 @@ Ext.define('PBS.DataStoreContent', {
 		'backup-time',
 	    ]);
 	    Proxmox.Utils.monStoreErrors(view, this.store);
-	    this.reload(); // initial load
 	},
 
 	reload: function() {
@@ -625,6 +624,17 @@ Ext.define('PBS.DataStoreContent', {
 	},
     },
 
+    listeners: {
+	activate: function() {
+	    let me = this;
+	    // only load on first activate to not load every tab switch
+	    if (!me.firstLoad) {
+		me.getController().reload();
+		me.firstLoad = true;
+	    }
+	},
+    },
+
     viewConfig: {
 	getRowClass: function(record, index) {
 	    let verify = record.get('verification');
-- 
2.30.2





             reply	other threads:[~2021-10-01  9:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01  9:56 Dominik Csapak [this message]
2021-10-01  9:56 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: datastore/Content: add empty text for no snapshots Dominik Csapak
2021-10-04  8:29 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: datastore/Content: reload in activate listener Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211001095655.2678928-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal