From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v2 00/13] add 'protected' setting for snapshots
Date: Thu, 23 Sep 2021 13:37:26 +0200 [thread overview]
Message-ID: <20210923113739.4151043-1-d.csapak@proxmox.com> (raw)
add the means to 'protect' a snapshot against pruning and removal by
adding a file '.protected' in the snapshot folder
in the v2, i opted against syncing the protected flag for two reasons:
* it gives the admin the choice on each datastore if he wants to keep
the snapshot or not(if we sync it, we would have to sync it everytime?)
* it is much simpler to implement
changes from v1:
* rebase on master
* return the PruneMark enum instead of two booleans in compute_prune_info
* lock the snapshot when setting/removig the flag
* don't bail if the file does not exist on removal
* add a 'protected show' command to the client
* add a docs section to explain the protected flag
changes from rfc:
* added gui parts
* added tests
* fixed a bug (that the test uncovered)
* add pbs client command
* prevent removal (also during sync)
Dominik Csapak (13):
pbs-datastore: add protection info to BackupInfo
pbs-datastore: skip protected backups in pruning
add protected info of snapshots to api and task logs
tests/prune: add tests for protecteded backups
backup/datastore: prevent protected snapshots to be removed
pull_store/group: dont try remove locally protected snapshots
api2: datastore/delete_group: throw error for partially removed group
api2/admin/datastore: add get/set_protection
proxmox-backup-client: add 'protected' commands
ui: PruneInputPanel: add keepReason 'protected' for protected backups
ui: add protected icon to snapshots
fix #3602: ui: datastore/Content: add action to set protection status
docs: add info about protection flag to client docs
docs/backup-client.rst | 19 +++++
pbs-api-types/src/datastore.rs | 2 +
pbs-datastore/src/backup_info.rs | 20 ++++-
pbs-datastore/src/prune.rs | 44 ++++++++--
proxmox-backup-client/src/snapshot.rs | 113 ++++++++++++++++++++++++++
src/api2/admin/datastore.rs | 111 +++++++++++++++++++++++--
src/backup/datastore.rs | 61 +++++++++++---
src/server/prune_job.rs | 6 +-
src/server/pull.rs | 19 ++++-
tests/prune.rs | 44 +++++++++-
www/datastore/Content.js | 75 +++++++++++++++++
www/datastore/Prune.js | 4 +
12 files changed, 481 insertions(+), 37 deletions(-)
--
2.30.2
next reply other threads:[~2021-09-23 11:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 11:37 Dominik Csapak [this message]
2021-09-23 11:37 ` [pbs-devel] [PATCH proxmox-backup v2 01/13] pbs-datastore: add protection info to BackupInfo Dominik Csapak
2021-09-23 11:37 ` [pbs-devel] [PATCH proxmox-backup v2 02/13] pbs-datastore: skip protected backups in pruning Dominik Csapak
2021-09-23 11:37 ` [pbs-devel] [PATCH proxmox-backup v2 03/13] add protected info of snapshots to api and task logs Dominik Csapak
2021-09-23 11:37 ` [pbs-devel] [PATCH proxmox-backup v2 04/13] tests/prune: add tests for protecteded backups Dominik Csapak
2021-09-23 11:37 ` [pbs-devel] [PATCH proxmox-backup v2 05/13] backup/datastore: prevent protected snapshots to be removed Dominik Csapak
2021-09-23 11:37 ` [pbs-devel] [PATCH proxmox-backup v2 06/13] pull_store/group: dont try remove locally protected snapshots Dominik Csapak
2021-09-23 11:37 ` [pbs-devel] [PATCH proxmox-backup v2 07/13] api2: datastore/delete_group: throw error for partially removed group Dominik Csapak
2021-09-23 11:37 ` [pbs-devel] [PATCH proxmox-backup v2 08/13] api2/admin/datastore: add get/set_protection Dominik Csapak
2021-09-23 11:37 ` [pbs-devel] [PATCH proxmox-backup v2 09/13] proxmox-backup-client: add 'protected' commands Dominik Csapak
2021-09-23 11:37 ` [pbs-devel] [PATCH proxmox-backup v2 10/13] ui: PruneInputPanel: add keepReason 'protected' for protected backups Dominik Csapak
2021-09-23 11:37 ` [pbs-devel] [PATCH proxmox-backup v2 11/13] ui: add protected icon to snapshots Dominik Csapak
2021-09-23 11:37 ` [pbs-devel] [PATCH proxmox-backup v2 12/13] fix #3602: ui: datastore/Content: add action to set protection status Dominik Csapak
2021-09-23 11:37 ` [pbs-devel] [PATCH proxmox-backup v2 13/13] docs: add info about protection flag to client docs Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923113739.4151043-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox