public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH v2 backup] zsh: fix completions
@ 2021-09-02 11:48 Oguz Bektas
  2021-09-03  8:53 ` [pbs-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Oguz Bektas @ 2021-09-02 11:48 UTC (permalink / raw)
  To: pbs-devel

seems like there was a typo in these from the beginning.

also fixes the wrong function name for proxmox-file-restore completion

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
v1->v2:
* fix the other typo i made in proxmox-backup-debug...


 zsh-completions/_pmt                    | 2 +-
 zsh-completions/_pmtx                   | 2 +-
 zsh-completions/_proxmox-backup-client  | 2 +-
 zsh-completions/_proxmox-backup-debug   | 2 +-
 zsh-completions/_proxmox-backup-manager | 2 +-
 zsh-completions/_proxmox-file-restore   | 6 +++---
 zsh-completions/_proxmox-tape           | 2 +-
 zsh-completions/_pxar                   | 2 +-
 8 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/zsh-completions/_pmt b/zsh-completions/_pmt
index dc418dfa..3fadd498 100644
--- a/zsh-completions/_pmt
+++ b/zsh-completions/_pmt
@@ -2,7 +2,7 @@
 
 function _pmt() {
     local cwords line point cmd curr prev
-    cworkds=${#words[@]}
+    cwords=${#words[@]}
     line=$words
     point=${#line}
     cmd=${words[1]}
diff --git a/zsh-completions/_pmtx b/zsh-completions/_pmtx
index 7269e82e..41fb52ef 100644
--- a/zsh-completions/_pmtx
+++ b/zsh-completions/_pmtx
@@ -2,7 +2,7 @@
 
 function _pmtx() {
     local cwords line point cmd curr prev
-    cworkds=${#words[@]}
+    cwords=${#words[@]}
     line=$words
     point=${#line}
     cmd=${words[1]}
diff --git a/zsh-completions/_proxmox-backup-client b/zsh-completions/_proxmox-backup-client
index 589ff7dd..f7e6f3f0 100644
--- a/zsh-completions/_proxmox-backup-client
+++ b/zsh-completions/_proxmox-backup-client
@@ -2,7 +2,7 @@
 
 function _proxmox-backup-client() {
     local cwords line point cmd curr prev
-    cworkds=${#words[@]}
+    cwords=${#words[@]}
     line=$words
     point=${#line}
     cmd=${words[1]}
diff --git a/zsh-completions/_proxmox-backup-debug b/zsh-completions/_proxmox-backup-debug
index d73c023f..caea4a04 100644
--- a/zsh-completions/_proxmox-backup-debug
+++ b/zsh-completions/_proxmox-backup-debug
@@ -2,7 +2,7 @@
 
 function _proxmox-backup-debug() {
     local cwords line point cmd curr prev
-    cworkds=${#words[@]}
+    cwords=${#words[@]}
     line=$words
     point=${#line}
     cmd=${words[1]}
diff --git a/zsh-completions/_proxmox-backup-manager b/zsh-completions/_proxmox-backup-manager
index 64a74af0..3b133796 100644
--- a/zsh-completions/_proxmox-backup-manager
+++ b/zsh-completions/_proxmox-backup-manager
@@ -2,7 +2,7 @@
 
 function _proxmox-backup-manager() {
     local cwords line point cmd curr prev
-    cworkds=${#words[@]}
+    cwords=${#words[@]}
     line=$words
     point=${#line}
     cmd=${words[1]}
diff --git a/zsh-completions/_proxmox-file-restore b/zsh-completions/_proxmox-file-restore
index e2e48c7a..98e7c2a3 100644
--- a/zsh-completions/_proxmox-file-restore
+++ b/zsh-completions/_proxmox-file-restore
@@ -1,8 +1,8 @@
-#compdef _proxmox-backup-client() proxmox-backup-client
+#compdef _proxmox-file-restore() proxmox-file-restore
 
-function _proxmox-backup-client() {
+function _proxmox-file-restore() {
     local cwords line point cmd curr prev
-    cworkds=${#words[@]}
+    cwords=${#words[@]}
     line=$words
     point=${#line}
     cmd=${words[1]}
diff --git a/zsh-completions/_proxmox-tape b/zsh-completions/_proxmox-tape
index d1490c85..88ebd56c 100644
--- a/zsh-completions/_proxmox-tape
+++ b/zsh-completions/_proxmox-tape
@@ -2,7 +2,7 @@
 
 function _proxmox-tape() {
     local cwords line point cmd curr prev
-    cworkds=${#words[@]}
+    cwords=${#words[@]}
     line=$words
     point=${#line}
     cmd=${words[1]}
diff --git a/zsh-completions/_pxar b/zsh-completions/_pxar
index 1b77a403..bf241d0d 100644
--- a/zsh-completions/_pxar
+++ b/zsh-completions/_pxar
@@ -2,7 +2,7 @@
 
 function _pxar() {
     local cwords line point cmd curr prev
-    cworkds=${#words[@]}
+    cwords=${#words[@]}
     line=$words
     point=${#line}
     cmd=${words[1]}
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied:  [PATCH v2 backup] zsh: fix completions
  2021-09-02 11:48 [pbs-devel] [PATCH v2 backup] zsh: fix completions Oguz Bektas
@ 2021-09-03  8:53 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-09-03  8:53 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Oguz Bektas

On 02.09.21 13:48, Oguz Bektas wrote:
> seems like there was a typo in these from the beginning.

all well, but as it worked just fine here in zsh it would be good to also
state what effects using the spelling variables had.

At least in my setup I could tab-complete also things like:
"proxmox-backup-manager network update ens18"

(I checked with execsnoop to see what command got executed, was the
"faulty" one before this patch)

maybe some smart-feature from my setup though

> 
> also fixes the wrong function name for proxmox-file-restore completion
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> v1->v2:
> * fix the other typo i made in proxmox-backup-debug...
> 
> 
>  zsh-completions/_pmt                    | 2 +-
>  zsh-completions/_pmtx                   | 2 +-
>  zsh-completions/_proxmox-backup-client  | 2 +-
>  zsh-completions/_proxmox-backup-debug   | 2 +-
>  zsh-completions/_proxmox-backup-manager | 2 +-
>  zsh-completions/_proxmox-file-restore   | 6 +++---
>  zsh-completions/_proxmox-tape           | 2 +-
>  zsh-completions/_pxar                   | 2 +-
>  8 files changed, 10 insertions(+), 10 deletions(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-03  8:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-02 11:48 [pbs-devel] [PATCH v2 backup] zsh: fix completions Oguz Bektas
2021-09-03  8:53 ` [pbs-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal