From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [RFC PATCH proxmox-backup 0/5] add 'protected' setting for snapshots
Date: Wed, 1 Sep 2021 10:25:34 +0200 [thread overview]
Message-ID: <20210901082539.1507843-1-d.csapak@proxmox.com> (raw)
add the means to 'protect' a snapshot against pruning by
adding a file '.protected' in the snapshot folder
sending as RFC because i am not sure about a couple things, and there
is no gui (yet):
* does it make sense to protect a snapshot this way? or would it be
better to have a 'central' protected list somewhere?
(sounds not right though..)
* would we want to protect also against manual removal ? or
'remove-vanished' on sync?
* how should the ui look? do we want *another* button in the content
view?
* would it make sense to specify this flag on backup creation too?
the finished series would fix #3602
Dominik Csapak (5):
pbs-datastore: add protection info to BackupInfo
pbs-datastore: skip protected backups in pruning
add protected info of snapshots to api and task logs
api2/admin/datastore: add get/set_protection
ui: PruneInputPanel: add keepReason 'protected' for protected backups
pbs-api-types/src/lib.rs | 2 +
pbs-datastore/src/backup_info.rs | 20 +++++-
pbs-datastore/src/prune.rs | 21 +++---
src/api2/admin/datastore.rs | 112 ++++++++++++++++++++++++++++++-
src/server/prune_job.rs | 4 +-
www/datastore/Prune.js | 4 ++
6 files changed, 148 insertions(+), 15 deletions(-)
--
2.30.2
next reply other threads:[~2021-09-01 8:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 8:25 Dominik Csapak [this message]
2021-09-01 8:25 ` [pbs-devel] [RFC PATCH proxmox-backup 1/5] pbs-datastore: add protection info to BackupInfo Dominik Csapak
2021-09-01 8:25 ` [pbs-devel] [RFC PATCH proxmox-backup 2/5] pbs-datastore: skip protected backups in pruning Dominik Csapak
2021-09-01 8:25 ` [pbs-devel] [RFC PATCH proxmox-backup 3/5] add protected info of snapshots to api and task logs Dominik Csapak
2021-09-01 8:25 ` [pbs-devel] [RFC PATCH proxmox-backup 4/5] api2/admin/datastore: add get/set_protection Dominik Csapak
2021-09-01 8:25 ` [pbs-devel] [RFC PATCH proxmox-backcup 5/5] ui: PruneInputPanel: add keepReason 'protected' for protected backups Dominik Csapak
2021-09-02 6:25 ` [pbs-devel] [RFC PATCH proxmox-backup 0/5] add 'protected' setting for snapshots Thomas Lamprecht
2021-09-02 6:45 Dietmar Maurer
2021-09-02 6:48 ` Thomas Lamprecht
2021-09-02 7:05 Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210901082539.1507843-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox