From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: fix order of prune keep reasons
Date: Mon, 30 Aug 2021 10:30:09 +0200 [thread overview]
Message-ID: <20210830083009.1853983-1-d.csapak@proxmox.com> (raw)
two things wrong with the old code:
* the sort function wants -1, 0 and 1 as a return value for a<b, a==b and a>b
respectively, not a bool (which a < b returns)
* we have to sort the newest backups first, since the first reason is
'keep-last'. until now, we sorted the oldest backup first, resulting
in the older backups getting the 'keep-last' reason
reported by a user in the forum:
https://forum.proxmox.com/threads/prune-ui-and-prune-schedule-simulator-dont-match.94944/
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/datastore/Prune.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/datastore/Prune.js b/www/datastore/Prune.js
index 3e74269f..42ea21bf 100644
--- a/www/datastore/Prune.js
+++ b/www/datastore/Prune.js
@@ -86,7 +86,7 @@ Ext.define('PBS.Datastore.PruneInputPanel', {
let counter = {};
backups.sort(function(a, b) {
- return a["backup-time"] < b["backup-time"];
+ return b["backup-time"] - a["backup-time"];
});
let ruleIndex = -1;
--
2.30.2
next reply other threads:[~2021-08-30 8:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 8:30 Dominik Csapak [this message]
2021-08-30 13:31 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830083009.1853983-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox