* [pbs-devel] [PATCH proxmox-backup] tape: lto: increase default timeout to 10 minutes
@ 2021-08-03 6:28 Dominik Csapak
2021-08-03 7:19 ` [pbs-devel] applied: " Dietmar Maurer
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-08-03 6:28 UTC (permalink / raw)
To: pbs-devel
it seems that for some actions or in some circumstances, two minutes is
simply too short and the command aborts. Increase the default timeout to
10 minutes.
While it should give most commands enough time to finish, in case of a real
failure the procedure now takes up to 5 times longer, but IMHO thats an
OK tradeoff.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/tape/drive/lto/sg_tape.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tape/drive/lto/sg_tape.rs b/src/tape/drive/lto/sg_tape.rs
index 4508f6f3..893ece5d 100644
--- a/src/tape/drive/lto/sg_tape.rs
+++ b/src/tape/drive/lto/sg_tape.rs
@@ -130,7 +130,7 @@ pub struct SgTape {
impl SgTape {
- const SCSI_TAPE_DEFAULT_TIMEOUT: usize = 60*2; // 2 minutes
+ const SCSI_TAPE_DEFAULT_TIMEOUT: usize = 60*10; // 10 minutes
/// Create a new instance
///
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* [pbs-devel] applied: [PATCH proxmox-backup] tape: lto: increase default timeout to 10 minutes
2021-08-03 6:28 [pbs-devel] [PATCH proxmox-backup] tape: lto: increase default timeout to 10 minutes Dominik Csapak
@ 2021-08-03 7:19 ` Dietmar Maurer
0 siblings, 0 replies; 2+ messages in thread
From: Dietmar Maurer @ 2021-08-03 7:19 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Dominik Csapak
applied
On 8/3/21 8:28 AM, Dominik Csapak wrote:
> it seems that for some actions or in some circumstances, two minutes is
> simply too short and the command aborts. Increase the default timeout to
> 10 minutes.
>
> While it should give most commands enough time to finish, in case of a real
> failure the procedure now takes up to 5 times longer, but IMHO thats an
> OK tradeoff.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/tape/drive/lto/sg_tape.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/tape/drive/lto/sg_tape.rs b/src/tape/drive/lto/sg_tape.rs
> index 4508f6f3..893ece5d 100644
> --- a/src/tape/drive/lto/sg_tape.rs
> +++ b/src/tape/drive/lto/sg_tape.rs
> @@ -130,7 +130,7 @@ pub struct SgTape {
>
> impl SgTape {
>
> - const SCSI_TAPE_DEFAULT_TIMEOUT: usize = 60*2; // 2 minutes
> + const SCSI_TAPE_DEFAULT_TIMEOUT: usize = 60*10; // 10 minutes
>
> /// Create a new instance
> ///
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-03 7:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-03 6:28 [pbs-devel] [PATCH proxmox-backup] tape: lto: increase default timeout to 10 minutes Dominik Csapak
2021-08-03 7:19 ` [pbs-devel] applied: " Dietmar Maurer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox