public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 0/3] improve status page decoding
Date: Wed, 28 Jul 2021 12:05:08 +0200	[thread overview]
Message-ID: <20210728100511.2862784-1-d.csapak@proxmox.com> (raw)

by better checking the amount of data available vs what we expect,
and by adding some tests (valid and non-valid data)

triggered by a report in the forum:
https://forum.proxmox.com/threads/decode-element-status-failed-failed-to-fill-whole-buffer.93041/

note: 2/3 tests added would fail without the first two patches

Dominik Csapak (3):
  tape: changer: remove unnecesary inquiry parameter
  tape: changer: handle libraries that sends wrong amount of data
  tape: changer: add tests for decode_element_status_page

 src/tape/changer/sg_pt_changer.rs | 162 ++++++++++++++++++++++++++++--
 1 file changed, 153 insertions(+), 9 deletions(-)

-- 
2.30.2





             reply	other threads:[~2021-07-28 10:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 10:05 Dominik Csapak [this message]
2021-07-28 10:05 ` [pbs-devel] [PATCH proxmox-backup 1/3] tape: changer: remove unnecesary inquiry parameter Dominik Csapak
2021-07-28 10:20   ` [pbs-devel] applied: " Dietmar Maurer
2021-07-28 10:05 ` [pbs-devel] [PATCH proxmox-backup 2/3] tape: changer: handle libraries that sends wrong amount of data Dominik Csapak
2021-07-28 10:35   ` [pbs-devel] applied: " Dietmar Maurer
2021-07-28 10:05 ` [pbs-devel] [PATCH proxmox-backup 3/3] tape: changer: add tests for decode_element_status_page Dominik Csapak
2021-07-28 10:35   ` [pbs-devel] applied: " Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210728100511.2862784-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal