public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: tape/ChangerStatus: improve layout for large libraries
Date: Fri, 23 Jul 2021 08:31:51 +0200	[thread overview]
Message-ID: <20210723063151.292363-1-d.csapak@proxmox.com> (raw)

instead of having the grid be as tall as possible and the containing
panel scroll. limit the grids height to the panel size and scroll the
grid.

this has two advantages:
* if a user has many slots, it is now possible to to navigate the other
  grids to the position wanted
* having the grids scroll, means it can use extjs' buffered renderer,
  which makes the view much more responsive (in case of hundreds of
  slots)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/ChangerStatus.js | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index 97b8f78e..a99b6ba6 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -693,9 +693,8 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 	},
     ],
 
-    layout: 'auto',
+    layout: 'fit',
     bodyPadding: 5,
-    scrollable: true,
 
     items: [
 	{
@@ -703,7 +702,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 	    reference: 'content',
 	    layout: {
 		type: 'hbox',
-		aling: 'stretch',
+		align: 'stretch',
 	    },
 	    items: [
 		{
@@ -711,6 +710,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 		    reference: 'slots',
 		    title: gettext('Slots'),
 		    padding: 5,
+		    srollable: true,
 		    flex: 1,
 		    store: {
 			type: 'diff',
@@ -771,10 +771,16 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 		    defaults: {
 			padding: 5,
 		    },
+		    layout: {
+			type: 'vbox',
+			align: 'stretch',
+		    },
 		    items: [
 			{
 			    xtype: 'grid',
 			    reference: 'drives',
+			    scrollable: true,
+			    maxHeight: 350, // ~10 drives
 			    title: gettext('Drives'),
 			    store: {
 				type: 'diff',
@@ -918,6 +924,8 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 			{
 			    xtype: 'grid',
 			    reference: 'import_export',
+			    flex: 1,
+			    srollable: true,
 			    store: {
 				type: 'diff',
 				rstore: {
-- 
2.30.2





             reply	other threads:[~2021-07-23  6:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23  6:31 Dominik Csapak [this message]
2021-07-26  8:12 ` [pbs-devel] applied: " Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210723063151.292363-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal