From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v2 2/6] tape: changer: sg_pt: add SCSI_VOLUME_TAG_LEN const
Date: Wed, 21 Jul 2021 17:10:39 +0200 [thread overview]
Message-ID: <20210721151043.2906767-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210721151043.2906767-1-d.csapak@proxmox.com>
so that we do have less 'magic' constants without description
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
no change in v2
src/tape/changer/sg_pt_changer.rs | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/tape/changer/sg_pt_changer.rs b/src/tape/changer/sg_pt_changer.rs
index f4154ced..908311b0 100644
--- a/src/tape/changer/sg_pt_changer.rs
+++ b/src/tape/changer/sg_pt_changer.rs
@@ -33,6 +33,7 @@ use crate::{
};
const SCSI_CHANGER_DEFAULT_TIMEOUT: usize = 60*5; // 5 minutes
+const SCSI_VOLUME_TAG_LEN: usize = 36;
/// Initialize element status (Inventory)
pub fn initialize_element_status<F: AsRawFd>(file: &mut F) -> Result<(), Error> {
@@ -509,7 +510,7 @@ impl SubHeader {
) -> Result<Option<String>, Error> {
if (self.flags & 128) != 0 { // has PVolTag
- let tmp = reader.read_exact_allocated(36)?;
+ let tmp = reader.read_exact_allocated(SCSI_VOLUME_TAG_LEN)?;
if full {
let volume_tag = scsi_ascii_to_string(&tmp);
return Ok(Some(volume_tag));
@@ -526,7 +527,7 @@ impl SubHeader {
) -> Result<Option<String>, Error> {
if (self.flags & 64) != 0 { // has AVolTag
- let _tmp = reader.read_exact_allocated(36)?;
+ let _tmp = reader.read_exact_allocated(SCSI_VOLUME_TAG_LEN)?;
}
Ok(None)
--
2.30.2
next prev parent reply other threads:[~2021-07-21 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 15:10 [pbs-devel] [PATCH proxmox-backup v2 1/6] api: types: CHANGER_DRIVENUM_SCHEMA: increase maximum drives per changer Dominik Csapak
2021-07-21 15:10 ` Dominik Csapak [this message]
2021-07-21 15:10 ` [pbs-devel] [PATCH proxmox-backup v2 3/6] tape: changer: sg_pt: fix typo Dominik Csapak
2021-07-21 15:10 ` [pbs-devel] [PATCH proxmox-backup v2 4/6] tape: changer: sg_pt: extend volume tag parsing Dominik Csapak
2021-07-21 15:10 ` [pbs-devel] [PATCH proxmox-backup v2 5/6] tape: changer: sg_pt: correctly consume data in decode_element_status_page Dominik Csapak
2021-07-21 15:10 ` [pbs-devel] [PATCH proxmox-backup v2 6/6] tape: changer: sg_pt: improve error message on wrong counts Dominik Csapak
2021-07-21 15:12 ` [pbs-devel] [PATCH proxmox-backup v2 1/6] api: types: CHANGER_DRIVENUM_SCHEMA: increase maximum drives per changer Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721151043.2906767-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox