From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 10/11] ui: datastore/Content: add 'Prune All' button
Date: Fri, 16 Jul 2021 10:53:27 +0200 [thread overview]
Message-ID: <20210716085328.3731574-11-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210716085328.3731574-1-d.csapak@proxmox.com>
since the api call always starts a real worker, we cannot have a
preview. It would also be very hard to show that for all groups in a
non-confusing way. We reuse the pbsPruneInputPanel and add the dry-run
field there conditionally.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/datastore/Content.js | 34 ++++++++++++++++++++++++++++++++++
www/window/DataStoreEdit.js | 15 +++++++++++++++
2 files changed, 49 insertions(+)
diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index ac8ae1cc..57693785 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -340,6 +340,35 @@ Ext.define('PBS.DataStoreContent', {
});
},
+ pruneAll: function() {
+ let me = this;
+ let view = me.getView();
+
+ if (!view.datastore) return;
+
+ Ext.create('Proxmox.window.Edit', {
+ title: `Prune Datastore '${view.datastore}'`,
+ onlineHelp: 'maintenance_pruning',
+
+ method: 'POST',
+ submitText: "Prune",
+ autoShow: true,
+ isCreate: true,
+ showTaskViewer: true,
+
+ taskDone: () => me.reload(),
+
+ url: `/api2/extjs/admin/datastore/${view.datastore}/prune-datastore`,
+
+ items: [
+ {
+ xtype: 'pbsPruneInputPanel',
+ dryrun: true,
+ },
+ ],
+ });
+ },
+
onVerify: function(view, rI, cI, item, e, rec) {
let me = this;
view = me.getView();
@@ -865,6 +894,11 @@ Ext.define('PBS.DataStoreContent', {
confirmMsg: gettext('Do you want to verify all snapshots now?'),
handler: 'verifyAll',
},
+ {
+ xtype: 'proxmoxButton',
+ text: gettext('Prune All'),
+ handler: 'pruneAll',
+ },
'->',
{
xtype: 'tbtext',
diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js
index fbf0da5b..ed23ad11 100644
--- a/www/window/DataStoreEdit.js
+++ b/www/window/DataStoreEdit.js
@@ -6,6 +6,9 @@ Ext.define('PBS.panel.PruneInputPanel', {
onlineHelp: 'maintenance_pruning',
+ // show/hide dry-run field
+ dryrun: false,
+
cbindData: function() {
let me = this;
me.isCreate = !!me.isCreate;
@@ -65,6 +68,18 @@ Ext.define('PBS.panel.PruneInputPanel', {
},
],
+ columnB: [
+ {
+ xtype: 'proxmoxcheckbox',
+ name: 'dry-run',
+ fieldLabel: gettext('Dry Run'),
+ cbind: {
+ hidden: '{!dryrun}',
+ disabled: '{!dryrun}',
+ },
+ },
+ ],
+
});
Ext.define('PBS.DataStoreEdit', {
extend: 'Proxmox.window.Edit',
--
2.30.2
next prev parent reply other threads:[~2021-07-16 8:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 8:53 [pbs-devel] [PATCH proxmox-backup 00/11] add 'prune all' button to datastore content Dominik Csapak
2021-07-16 8:53 ` [pbs-devel] [PATCH proxmox-backup 01/11] api-types: move PRUNE_SCHEMA_KEEP_* to pbs-api-types Dominik Csapak
2021-07-16 8:53 ` [pbs-devel] [PATCH proxmox-backup 02/11] pbs-datastore/prune: make PruneOptions an api type Dominik Csapak
2021-07-16 8:53 ` [pbs-devel] [PATCH proxmox-backup 03/11] client: simplify prune api method Dominik Csapak
2021-07-16 8:53 ` [pbs-devel] [PATCH proxmox-backup 04/11] api: admin/datastore: simplify prune api call Dominik Csapak
2021-07-16 8:53 ` [pbs-devel] [PATCH proxmox-backup 05/11] backup/datastore: refactor check_backup_owner there Dominik Csapak
2021-07-16 8:53 ` [pbs-devel] [PATCH proxmox-backup 06/11] server/prune_job: factor out 'prune_datastore' Dominik Csapak
2021-07-16 8:53 ` [pbs-devel] [PATCH proxmox-backup 07/11] server/prune_job: add 'keep_all' logic to 'prune_datastore' Dominik Csapak
2021-07-16 8:53 ` [pbs-devel] [PATCH proxmox-backup 08/11] server/prune_job: add proper permission checks " Dominik Csapak
2021-07-16 8:53 ` [pbs-devel] [PATCH proxmox-backup 09/11] api: admin/datastore: add new 'prune-datastore' api call Dominik Csapak
2021-07-16 8:53 ` Dominik Csapak [this message]
2021-07-16 8:53 ` [pbs-devel] [PATCH proxmox-backup 11/11] ui: datastore/Prune: improve title of group prune window Dominik Csapak
2021-07-16 9:48 ` [pbs-devel] applied: [PATCH proxmox-backup 00/11] add 'prune all' button to datastore content Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716085328.3731574-11-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox