From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/2] chunk_store/insert_chunk: add more information to file errors
Date: Tue, 13 Jul 2021 11:11:24 +0200 [thread overview]
Message-ID: <20210713091125.2064985-1-d.csapak@proxmox.com> (raw)
otherwise this context is missing in some tasks (e.g. tape restore)
and it is unclear where it came from
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
pbs-datastore/src/chunk_store.rs | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/pbs-datastore/src/chunk_store.rs b/pbs-datastore/src/chunk_store.rs
index ddf0a769..361cc9a2 100644
--- a/pbs-datastore/src/chunk_store.rs
+++ b/pbs-datastore/src/chunk_store.rs
@@ -401,12 +401,26 @@ impl ChunkStore {
let mut tmp_path = chunk_path.clone();
tmp_path.set_extension("tmp");
- let mut file = std::fs::File::create(&tmp_path)?;
+ let mut file = std::fs::File::create(&tmp_path).map_err(|err| {
+ format_err!(
+ "creating temporary chunk on store '{}' failed for {} - {}",
+ self.name,
+ digest_str,
+ err
+ )
+ })?;
let raw_data = chunk.raw_data();
let encoded_size = raw_data.len() as u64;
- file.write_all(raw_data)?;
+ file.write_all(raw_data).map_err(|err| {
+ format_err!(
+ "writing temporary chunk on store '{}' failed for {} - {}",
+ self.name,
+ digest_str,
+ err
+ )
+ })?;
if let Err(err) = std::fs::rename(&tmp_path, &chunk_path) {
if std::fs::remove_file(&tmp_path).is_err() { /* ignore */ }
--
2.30.2
next reply other threads:[~2021-07-13 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 9:11 Dominik Csapak [this message]
2021-07-13 9:11 ` [pbs-devel] [PATCH proxmox-backup 2/2] api2: tape: restore: add warning for list restore Dominik Csapak
2021-07-13 10:05 ` [pbs-devel] applied: " Dietmar Maurer
2021-07-13 9:56 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] chunk_store/insert_chunk: add more information to file errors Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713091125.2064985-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox