[pbs-devel] [PATCH proxmox-backup] ui: NodeInfo: add link to repositories

[pbs-devel] [PATCH proxmox-backup] ui: NodeInfo: add link to repositories

[Dominik Csapak]

to guide the user to the repository panel from the dashboard

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/panel/NodeInfo.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/www/panel/NodeInfo.js b/www/panel/NodeInfo.js
index ff96e8fc..d05a53d1 100644
--- a/www/panel/NodeInfo.js
+++ b/www/panel/NodeInfo.js
@@ -46,7 +46,9 @@ Ext.define('PBS.NodeInfoPanel', {
 	    },
 	    repoStatusMessage: function(get) {
 		const status = get('repoStatus');
-		return Proxmox.Utils.formatNodeRepoStatus(status, 'Proxmox Backup Server');
+		let link = '#pbsServerAdministration:aptrepositories';
+		let icon = ` <a href="${link}"><i class="fa fa-link"></i></a>`;
+		return Proxmox.Utils.formatNodeRepoStatus(status, 'Proxmox Backup Server') + icon;
 	    },
 	},
     },
-- 
2.30.2

Re: [pbs-devel] [PATCH proxmox-backup] ui: NodeInfo: add link to repositories

[Thomas Lamprecht]

On 12.07.21 13:54, Dominik Csapak wrote:
> to guide the user to the repository panel from the dashboard
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/panel/NodeInfo.js | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/www/panel/NodeInfo.js b/www/panel/NodeInfo.js
> index ff96e8fc..d05a53d1 100644
> --- a/www/panel/NodeInfo.js
> +++ b/www/panel/NodeInfo.js
> @@ -46,7 +46,9 @@ Ext.define('PBS.NodeInfoPanel', {
>  	    },
>  	    repoStatusMessage: function(get) {
>  		const status = get('repoStatus');
> -		return Proxmox.Utils.formatNodeRepoStatus(status, 'Proxmox Backup Server');
> +		let link = '#pbsServerAdministration:aptrepositories';
> +		let icon = ` <a href="${link}"><i class="fa fa-link"></i></a>`;

avoid over-general variable names, `repoLink` (and the link inline).

But actually I do not like this being a normal link, which gets purple once visited.
Also the symbol isn't really clear in this context, a `fa-arrow-circle-o-right` could be easier
to get the "goto" meaning, then some hover feedback would be also good (if we keep this
icon only I'd do similar to what we do for the action-column icons in the datastore content
panel. A tooltip could then be good to, to underline what this clickable element actually
does.



> +		return Proxmox.Utils.formatNodeRepoStatus(status, 'Proxmox Backup Server') + icon;
>  	    },
>  	},
>      },
>