From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/2] tape: changer: sg_pt: do not retry on unknown errors
Date: Mon, 12 Jul 2021 12:22:08 +0200 [thread overview]
Message-ID: <20210712102209.3061802-1-d.csapak@proxmox.com> (raw)
we handle some special errors, but want to return all others, so do that
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/tape/changer/sg_pt_changer.rs | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/tape/changer/sg_pt_changer.rs b/src/tape/changer/sg_pt_changer.rs
index 31c38576..29b04ad6 100644
--- a/src/tape/changer/sg_pt_changer.rs
+++ b/src/tape/changer/sg_pt_changer.rs
@@ -100,10 +100,8 @@ fn execute_scsi_command<F: AsRawFd>(
loop {
match sg_raw.do_command(&cmd) {
Ok(data) => return Ok(data.to_vec()),
+ Err(err) if !retry => bail!("{} failed: {}", error_prefix, err),
Err(err) => {
- if !retry {
- bail!("{} failed: {}", error_prefix, err);
- }
if let ScsiError::Sense(ref sense) = err {
if sense.sense_key == SENSE_KEY_NO_SENSE ||
@@ -136,6 +134,7 @@ fn execute_scsi_command<F: AsRawFd>(
continue; // try again
}
}
+ bail!("{} failed: {}", error_prefix, err);
}
}
}
--
2.30.2
next reply other threads:[~2021-07-12 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 10:22 Dominik Csapak [this message]
2021-07-12 10:22 ` [pbs-devel] [PATCH proxmox-backup 2/2] tape: changer: sg_pt: correctly loop over MODE SENSE (B8h) Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712102209.3061802-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox