public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 5/5] Revert "api: access: domains: add ExtraRealmInfo and RealmInfo structs"
Date: Mon, 12 Jul 2021 09:48:08 +0200	[thread overview]
Message-ID: <20210712074808.1103102-8-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210712074808.1103102-1-d.csapak@proxmox.com>

This reverts commit da7ec1d2af1c28503052e1cd5954dfada81058cd.

not necessary, since we have the api in config/access/openid

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/api2/access/domain.rs | 65 ---------------------------------------
 1 file changed, 65 deletions(-)

diff --git a/src/api2/access/domain.rs b/src/api2/access/domain.rs
index bfc7c184..afa69269 100644
--- a/src/api2/access/domain.rs
+++ b/src/api2/access/domain.rs
@@ -9,7 +9,6 @@ use proxmox::api::{api, Permission, Router, RpcEnvironment};
 
 use crate::config;
 use crate::api2::types::*;
-use crate::config::domains::{OpenIdRealmConfig, OpenIdUserAttribute};
 
 #[api]
 #[derive(Deserialize, Serialize, PartialEq, Eq)]
@@ -52,70 +51,6 @@ pub struct BasicRealmInfo {
     pub comment: Option<String>,
 }
 
-#[api(
-    properties: {
-        "issuer-url": {
-            description: "OpenID Issuer Url",
-            type: String,
-            optional: true,
-        },
-        "client-id": {
-            description: "OpenID Client ID",
-            type: String,
-            optional: true,
-        },
-        "client-key": {
-            description: "OpenID Client Key",
-            type: String,
-            optional: true,
-        },
-        autocreate: {
-            description: "Automatically create users if they do not exist.",
-            optional: true,
-            type: bool,
-            default: false,
-        },
-        "username-claim": {
-            type: OpenIdUserAttribute,
-            optional: true,
-        },
-    },
-)]
-#[derive(Deserialize, Serialize)]
-#[serde(rename_all = "kebab-case")]
-/// Extra Information about a realm
-pub struct ExtraRealmInfo {
-    #[serde(skip_serializing_if = "Option::is_none")]
-    pub issuer_url: Option<String>,
-    #[serde(skip_serializing_if = "Option::is_none")]
-    pub client_id: Option<String>,
-    #[serde(skip_serializing_if = "Option::is_none")]
-    pub client_key: Option<String>,
-    #[serde(skip_serializing_if = "Option::is_none")]
-    pub autocreate: Option<bool>,
-    #[serde(skip_serializing_if = "Option::is_none")]
-    pub username_claim: Option<OpenIdUserAttribute>,
-}
-
-#[api(
-    properties: {
-        "info": {
-            type: BasicRealmInfo,
-        },
-        "extra": {
-            type: ExtraRealmInfo,
-        },
-    },
-)]
-#[derive(Deserialize, Serialize)]
-#[serde(rename_all = "kebab-case")]
-/// Information about a realm
-pub struct RealmInfo {
-    #[serde(flatten)]
-    pub info: BasicRealmInfo,
-    #[serde(flatten)]
-    pub extra: ExtraRealmInfo,
-}
 
 #[api(
     returns: {
-- 
2.30.2





  parent reply	other threads:[~2021-07-12  7:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12  7:48 [pbs-devel] [PATCH widget-toolkit/proxmox-backup] fix openid realm api usage Dominik Csapak
2021-07-12  7:48 ` [pbs-devel] [PATCH widget-toolkit 1/2] window/AuthEditBase: handle differenc config api urls Dominik Csapak
2021-07-12  7:48 ` [pbs-devel] [PATCH widget-toolkit 2/2] panel/AuthView: handle different baseUrls for configuring realms Dominik Csapak
2021-07-12  7:48 ` [pbs-devel] [PATCH proxmox-backup 1/5] ui: panel/AccessControl: define baseUrland useTypeInUrl for AuthView Dominik Csapak
2021-07-12  7:48 ` [pbs-devel] [PATCH proxmox-backup 2/5] api: config: access: openid: use correct parameter for matching Dominik Csapak
2021-07-12  7:48 ` [pbs-devel] [PATCH proxmox-backup 3/5] api: config: access: openid: use better Privilige Realm.Allocate Dominik Csapak
2021-07-12  7:48 ` [pbs-devel] [PATCH proxmox-backup 4/5] Revert "api: access: domains: add get/create/update/delete domain call" Dominik Csapak
2021-07-12  7:48 ` Dominik Csapak [this message]
2021-07-12  8:26 ` [pbs-devel] applied-series: [PATCH widget-toolkit/proxmox-backup] fix openid realm api usage Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210712074808.1103102-8-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal