From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/2] ui: form/DriveSelector: do not autoselect the drive
Date: Mon, 7 Jun 2021 15:06:44 +0200 [thread overview]
Message-ID: <20210607130645.11838-1-d.csapak@proxmox.com> (raw)
in case an invalid drive was configured, now it marks the field invalid
instead of autoselecting the first valid one
this could have lead to users configuring the wrong drive in a tape-backup-job
when they edited one
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/tape/form/DriveSelector.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/tape/form/DriveSelector.js b/www/tape/form/DriveSelector.js
index 333989a9..9c793e46 100644
--- a/www/tape/form/DriveSelector.js
+++ b/www/tape/form/DriveSelector.js
@@ -16,6 +16,8 @@ Ext.define('PBS.form.DriveSelector', {
sorters: 'name',
},
+ autoSelect: false,
+
listConfig: {
columns: [
{
--
2.20.1
next reply other threads:[~2021-06-07 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 13:06 Dominik Csapak [this message]
2021-06-07 13:06 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/TapeBackupJob: use correct default value for pbsUserSelector Dominik Csapak
2021-06-08 6:29 ` [pbs-devel] applied: " Thomas Lamprecht
2021-06-08 6:29 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: form/DriveSelector: do not autoselect the drive Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210607130645.11838-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox