From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 7/9] ui: MainView: use new beforeChangePath signature
Date: Wed, 26 May 2021 11:12:04 +0200 [thread overview]
Message-ID: <20210526091206.21979-8-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210526091206.21979-1-d.csapak@proxmox.com>
subpath can be optional in extjs 7.0, so handle that
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/MainView.js | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/www/MainView.js b/www/MainView.js
index cd63f4c7..ef52f094 100644
--- a/www/MainView.js
+++ b/www/MainView.js
@@ -34,9 +34,15 @@ Ext.define('PBS.MainView', {
return [xtype, config];
},
- beforeChangePath: function(path, subpath, action) {
+ beforeChangePath: function(path, subpathOrAction, action) {
var me = this;
+ let subpath = subpathOrAction;
+ if (!action) {
+ action = subpathOrAction;
+ subpath = undefined;
+ }
+
let [xtype, config] = me.parseRouterPath(path);
if (!Ext.ClassManager.getByAlias(`widget.${xtype}`)) {
--
2.20.1
next prev parent reply other threads:[~2021-05-26 9:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 9:11 [pbs-devel] [PATCH proxmox-backup 0/9] fixes/changes extjs 7.0 Dominik Csapak
2021-05-26 9:11 ` [pbs-devel] [PATCH proxmox-backup 1/9] ui: MainView: do not use unnecessary panels Dominik Csapak
2021-05-26 9:11 ` [pbs-devel] [PATCH proxmox-backup 2/9] ui: form/CalendarEvent: do not set displayField Dominik Csapak
2021-05-26 9:12 ` [pbs-devel] [PATCH proxmox-backup 3/9] ui: panel/UsageChart: change downloadServerUrl Dominik Csapak
2021-05-26 9:12 ` [pbs-devel] [PATCH proxmox-backup 4/9] ui: datastore/Summary: change destroy listener Dominik Csapak
2021-05-26 9:12 ` [pbs-devel] [PATCH proxmox-backup 5/9] ui: MainView: navigation: use different ui class Dominik Csapak
2021-05-26 9:12 ` [pbs-devel] [PATCH proxmox-backup 6/9] ui: css: fix text-align pmx-button-badge Dominik Csapak
2021-05-26 9:12 ` Dominik Csapak [this message]
2021-05-26 9:12 ` [pbs-devel] [PATCH proxmox-backup 8/9] ui: use isActionDisabled Dominik Csapak
2021-07-08 9:45 ` [pbs-devel] applied: " Thomas Lamprecht
2021-05-26 9:12 ` [pbs-devel] [PATCH proxmox-backup 9/9] ui: MainView: fix redirectTo call Dominik Csapak
2021-07-08 9:45 ` [pbs-devel] applied: " Thomas Lamprecht
2021-05-26 17:21 ` [pbs-devel] applied: [PATCH proxmox-backup 0/9] fixes/changes extjs 7.0 Thomas Lamprecht
2021-07-08 9:09 ` [pbs-devel] " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526091206.21979-8-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox