From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/2] ui: datastore/Content: fix wrong tooltip for forgetting
Date: Mon, 17 May 2021 09:03:14 +0200 [thread overview]
Message-ID: <20210517070315.4510-1-d.csapak@proxmox.com> (raw)
sometimes it's a group, not a snapshot
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/datastore/Content.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index 67ebbdac..ca90f82a 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -632,7 +632,9 @@ Ext.define('PBS.DataStoreContent', {
},
{
handler: 'onForget',
- getTip: (v, m, rec) => Ext.String.format(gettext("Permanently forget snapshot '{0}'"), v),
+ getTip: (v, m, rec) => rec.parentNode.id !=='root'
+ ? Ext.String.format(gettext("Permanently forget snapshot '{0}'"), v)
+ : Ext.String.format(gettext("Permanently forget group '{0}'"), v),
getClass: (v, m, rec) => !rec.data.leaf ? 'fa critical fa-trash-o' : 'pmx-hidden',
isDisabled: (v, r, c, i, rec) => !!rec.data.leaf,
},
--
2.20.1
next reply other threads:[~2021-05-17 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 7:03 Dominik Csapak [this message]
2021-05-17 7:03 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: datastore/Content: change group remove to SafeDestroy Window Dominik Csapak
2021-05-17 8:59 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: datastore/Content: fix wrong tooltip for forgetting Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517070315.4510-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox